← Back to team overview

oship-dev team mailing list archive

Re: [Branch ~oship-dev/oship/devel] Rev 468: The commit merges a simple way to add measurement sources to the trunk repository. It also fixes ...

 

2010/8/10 Tim Cook <timothywayne.cook@xxxxxxxxx>

> Just delete the mlhim directory.  BUT! do not name objects generically.
>
You mean the classes ?

> name this as specific to openehr.  There will be other reference models
> in later version of OSHIP.
>
> Just to clarify: I'm not against copy files to start a project, or a new
implementation at this case. Is important to keep in mind when you copying
files, you are carrying implementation details that not always is related to
new project, tests (sometimes creating a false sensation that tests are
growing because the quantity grew up) and at the end, duplicating
maintainability. Im my point of view, is better create directories with
empty files than with a stub behavior when you start a new implementation.
This approach appears interesting even to maintain the traceability of what
is implemented or not at the moment. So, When you copy files with code to
new implementatios, this situations must be clear in my mind: it can happen.

> Okay?
>
If it's your decision, I don't have questions.

>
> Tim
>
>
> On Tue, 2010-08-10 at 13:41 -0300, Diego Manhães Pinheiro wrote:
> >
> >
> > 2010/8/10 Diego Manhães Pinheiro <dmpinheiro@xxxxxxxxx>
> >
> >
> >         2010/8/10 Tim Cook <timothywayne.cook@xxxxxxxxx>
> >
> >                 On Tue, 2010-08-10 at 11:05 +0000,
> >                 noreply@xxxxxxxxxxxxx wrote:
> >                 > It also fixes a problem found on new mlhim
> >                 demographic module that was breaking some tests.
> >                 > added:
> >
> >
> >                 Hmmm, I don't think deleting the file constitutes a
> >                 fix.  :-)
> >         It was the simpler solution that I found to solve quickly the
> >         problem.
> >         As I noticed that mlhim is an initial stage, I could see any
> >         problem on do that.
> >         Is there any problem?
> >
> >
> >
> >                 I haven't edited this file since it was copied from
> >                 the openehr package
> >                 either.  So, it should be exactly like the demographic
> >                 module in
> >                 openehr.
> >
> >                 Can you explain what the problem is?
> >         Ok. The Grok mechanism was triggering some strange object
> >         events that weren't expected because there were two object
> >         catalogs with same name. If i'm right it's sounds like a bug,
> >         but I have to double check first. That's why I leaved the file
> >         empty. If you want, I can rollback the last file state, but
> >         without the catalog mechanism. Sorry, but I really have to
> >         verify this weird behaviour. If is your intention make mlhim
> >         module as a copy of the openehr(I mean with exactly equals),
> >         this wont be possible until I figure out which scenarios this
> >         bug happen.
> > Here is a example : http://pastebin.com/9cRvid2E
> >
> >                 Thanks,
> >                 Tim
> >
> >
> >
> >                 --
> >
> ***************************************************************
> >                 Timothy Cook, MSc
> >                 Project Lead - Multi-Level Healthcare Information
> >                 Modeling
> >                 http://www.mlhim.org
> >
> >                 LinkedIn
> >                 Profile:http://www.linkedin.com/in/timothywaynecook
> >                 Skype ID == timothy.cook
> >                 Academic.Edu Profile:
> >                 http://uff.academia.edu/TimothyCook
> >
> >                 You may get my Public GPG key from  popular keyservers
> >                 or
> >                 from this link
> >                 http://timothywayne.cook.googlepages.com/home
> >
> >
> >
> >                 _______________________________________________
> >                 Mailing list: https://launchpad.net/~oship-dev
> >                 Post to     : oship-dev@xxxxxxxxxxxxxxxxxxx
> >                 Unsubscribe : https://launchpad.net/~oship-dev
> >                 More help   : https://help.launchpad.net/ListHelp
> >
> >
> >
> >
> >
> >
> >         --
> >         http://dmpinheiro.net
> >         -----------------------------------
> >         Diego Manhães Pinheiro
> >
> >
> >
> >
> > --
> > http://dmpinheiro.net
> > -----------------------------------
> > Diego Manhães Pinheiro
> > _______________________________________________
> > Mailing list: https://launchpad.net/~oship-dev
> > Post to     : oship-dev@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~oship-dev
> > More help   : https://help.launchpad.net/ListHelp
>
> --
> ***************************************************************
> Timothy Cook, MSc
> Project Lead - Multi-Level Healthcare Information Modeling
> http://www.mlhim.org
>
> LinkedIn Profile:http://www.linkedin.com/in/timothywaynecook
> Skype ID == timothy.cook
> Academic.Edu Profile: http://uff.academia.edu/TimothyCook
>
> You may get my Public GPG key from  popular keyservers or
> from this link http://timothywayne.cook.googlepages.com/home
>
>


-- 
http://dmpinheiro.net
-----------------------------------
Diego Manhães Pinheiro

Follow ups

References