← Back to team overview

oship-dev team mailing list archive

[Bug 623612] [NEW] issues in class Locatable in package common

 

Public bug reported:

nameValid, linksValid, archetypedValid, archetypeNodeIdValid are not methods but invariants. Their current implementations can be used to enforce the following invariants:
Links_valid: links /= Void implies not links.empty
Archetyped_valid: is_archetype_root xor archetype_details = Void
Archetype_node_id_valid: archetype_node_id /= Void and then not archetype_node_id.is_empty

The invariant Name_valid is already enforced by the respective schema.

According to previous discussions, maybe we should leave the methods
__eq__ and __hash__ as their default.

** Affects: oship
     Importance: High
         Status: New

** Changed in: oship
   Importance: Undecided => High

-- 
issues in class Locatable in package common
https://bugs.launchpad.net/bugs/623612
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.

Status in Open Source Health Information Platform (OSHIP): New

Bug description:
nameValid, linksValid, archetypedValid, archetypeNodeIdValid are not methods but invariants. Their current implementations can be used to enforce the following invariants:
Links_valid: links /= Void implies not links.empty
Archetyped_valid: is_archetype_root xor archetype_details = Void
Archetype_node_id_valid: archetype_node_id /= Void and then not archetype_node_id.is_empty

The invariant Name_valid is already enforced by the respective schema.

According to previous discussions, maybe we should leave the methods __eq__ and __hash__ as their default.





Follow ups

References