← Back to team overview

oship-dev team mailing list archive

[Bug 625622] Re: issues in AuditDetails and IAuditDetails

 

** Project changed: oship => oshippy

** Changed in: oshippy
    Milestone: 1.5 => None

-- 
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.
https://bugs.launchpad.net/bugs/625622

Title:
  issues in AuditDetails and IAuditDetails

Status in Open Source Health Information Platform - Python:
  In Progress

Bug description:
  systemIdValid, committerValid, timeCommittedValid and changeTypeValid
  are not methods but invariants that should be enforced.

  System_id_valid: system_id /= Void and then not system_id.is_empty
  Change_type_valid: change_type /= Void and then terminology(Terminology_id_openehr).has_code_for_group_id(Group_id_audit_change_type, change_type.defining_code)

  change_type invariant should be implemented through the terminological
  service.

  Maybe it would be interesting to define a representation method for
  this class.





References