oship-dev team mailing list archive

[Sergio Miranda Freire <sergio@xxxxxxxxxxxxxxx>]

Public bug reported:

systemIdValid, committerValid, timeCommittedValid and changeTypeValid
are not methods but invariants that should be enforced.

System_id_valid: system_id /= Void and then not system_id.is_empty
Change_type_valid: change_type /= Void and then terminology(Terminology_id_openehr).has_code_for_group_id(Group_id_audit_change_type, change_type.defining_code)

change_type invariant should be implemented through the terminological
service.

Maybe it would be interesting to define a representation method for this
class.

** Affects: oship
     Importance: High
         Status: New

** Changed in: oship
   Importance: Undecided => High

-- 
issues in AuditDetails and IAuditDetails
https://bugs.launchpad.net/bugs/625622
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.

Status in Open Source Health Information Platform (OSHIP): New

Bug description:
systemIdValid, committerValid, timeCommittedValid and changeTypeValid are not methods but invariants that should be enforced.

System_id_valid: system_id /= Void and then not system_id.is_empty
Change_type_valid: change_type /= Void and then terminology(Terminology_id_openehr).has_code_for_group_id(Group_id_audit_change_type, change_type.defining_code)

change_type invariant should be implemented through the terminological service.

Maybe it would be interesting to define a representation method for this class.