← Back to team overview

phpdevshell team mailing list archive

[Bug 1032653] [NEW] Wrong array name in PHPDS_importUser.class importPrep

 

Public bug reported:

I think the importPrep function contained in the PHPDS_importUser.class
is passing the incorrect array reference to importArray function.

It should be passing $import_data, which is its only parameter, instead
of the $import_array, which is uninitialized.  This causes an exception
to be thrown in importArray.

       currently is:
	public function importPrep($import_data)
	{
		if (($import_data['user_display_name'] == _('MISSING???')) || empty($import_data['user_display_name'])) {
			$import_data['user_display_name'] = $import_data['user_name'];
		}

		$this->importArray($import_array);
		
		return $this;
	}

       should be:
	public function importPrep($import_data)
	{
		if (($import_data['user_display_name'] == _('MISSING???')) || empty($import_data['user_display_name'])) {
			$import_data['user_display_name'] = $import_data['user_name'];
		}

		$this->importArray($import_data);
		
		return $this;
	}

** Affects: phpdevshell
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of
PHPDevShell, which is subscribed to PHPDevShell.
https://bugs.launchpad.net/bugs/1032653

Title:
  Wrong array name in PHPDS_importUser.class importPrep

Status in Open Source PHP RAD Framework with UI.:
  New

Bug description:
  I think the importPrep function contained in the
  PHPDS_importUser.class is passing the incorrect array reference to
  importArray function.

  It should be passing $import_data, which is its only parameter,
  instead of the $import_array, which is uninitialized.  This causes an
  exception to be thrown in importArray.

         currently is:
  	public function importPrep($import_data)
  	{
  		if (($import_data['user_display_name'] == _('MISSING???')) || empty($import_data['user_display_name'])) {
  			$import_data['user_display_name'] = $import_data['user_name'];
  		}

  		$this->importArray($import_array);
  		
  		return $this;
  	}

         should be:
  	public function importPrep($import_data)
  	{
  		if (($import_data['user_display_name'] == _('MISSING???')) || empty($import_data['user_display_name'])) {
  			$import_data['user_display_name'] = $import_data['user_name'];
  		}

  		$this->importArray($import_data);
  		
  		return $this;
  	}

To manage notifications about this bug go to:
https://bugs.launchpad.net/phpdevshell/+bug/1032653/+subscriptions


Follow ups

References