pkg-perl-maintainers team mailing list archive

[Ioanna Alifieraki <2029379@xxxxxxxxxxxxxxxxxx>]

Review for Source Package: libdbd-sqlite3-perl

[Summary]
MIR team ACK.
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main: libdbd-sqlite3-perl
Specific binary packages built, but NOT to be promoted to main: <None>

Notes:
The package looks ok apart from the vendored code and CVE-2022-46908.

Regarding the vendored code (sqlite3) Ubuntu Server is aware of its implications and
commits to provide updates and backports to the security team for the lifetiem of 
the release (as per bug Description).
That said, we're godd on that front.

There's a CVE open in the upstream issues (https://github.com/DBD-SQLite/DBD-SQLite/issues/108),
therefore I suggest a security review.
Upstream is working on the next version (1.73) but is not yet stable (expected in mid September 2023),
which is supposed to take care of the CVE.

Required TODOs:
- The package should get a team bug subscriber before being promoted

[Duplication]
There is no other package in main providing the same functionality.
This package is required in main as a dependency of libmail-dmarc-perl.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
  - libdbd-sqlite3-perl checked with `check-mir`
  - all dependencies can be found in `seeded-in-ubuntu` (already in main)
  - none of the (potentially auto-generated) dependencies (Depends
    and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
TODO: - no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

Problems:
- embedded source present
- vendored code included

[Security]
OK:
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
   xml, json, asn.1], network packets, structures, ...) from
   an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

Problems:
- CVE-2022-46908  : https://github.com/DBD-SQLite/DBD-SQLite/issues/108

[Common blockers]
OK:
- does not FTBFS currently
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- the current release is packaged
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is (good/slow/sporadic)
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]

OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?

Problems: None


** Bug watch added: github.com/DBD-SQLite/DBD-SQLite/issues #108
   https://github.com/DBD-SQLite/DBD-SQLite/issues/108

** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2022-46908

** Changed in: libdbd-sqlite3-perl (Ubuntu)
     Assignee: Ioanna Alifieraki (joalif) => (unassigned)

** Changed in: libdbd-sqlite3-perl (Ubuntu)
     Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security)

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to libdbd-sqlite3-perl in Ubuntu.
https://bugs.launchpad.net/bugs/2029379

Title:
  [MIR] promote libdbd-sqlite3-perl (libmail-dmarc-perl dependency)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdbd-sqlite3-perl/+bug/2029379/+subscriptions