← Back to team overview

qpdfview team mailing list archive

qpdfview: request for comments and testing: Poppler 0.24 and threading

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello everybody,

If you follow Poppler's development, you may have noticed that support
for multi-threaded rendering using Splash has been merged yesterday.

Currently, this seems to imply, that we can render an arbitrary number
of pages concurrently, but we have to wait for rendering to stop until
doing anything else, e.g. searching the document. In the branch [1], I
tried to implement this condition using QReadWriteLock instead of
QMutex as the synchronization primitive.

Any comments on this would be appreciated. If you feel comfortable
with building Poppler using a Git snapshot, testing this would also be
very helpful. (Remember to correct the paths given in
"qpdfview-pdf-plugin.pro" which are currently set up for my system and
to change LD_LIBRARY_PATH accordingly when running the built executables.)

Another issue that needs to be decided: This change was merged into
Poppler's master branch and hence will almost surely be part of
Poppler 0.24, but there is the question of whether we should
incorporate those changes into our next release even if that predates
Poppler 0.24, so that e.g. qpdfview 0.4 will use the multi-threading
when Poppler 0.24 is released.

I already did something like this by having usage of Poppler 0.22's
improved Page::search method in qpdfview's releases before 0.22 was
released. And it seems to have worked well, but it is a much smaller
changed than enabling multi-threading. One the other hand, this
feature is very much sought after by a lot of people. What are your
thoughts? Try to have this in trunk as soon as possible or be more
cautious about integrating this?

Best regards, Adam.

[1] https://code.launchpad.net/~adamreichold/qpdfview/poppler-threading
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJQ+9DvAAoJEPSSjE3STU34UlEH/jb3iATDvj4jClAWmqUXuXU8
h7ng0G+3b59YSexlSj54yPeRBr27TWxd0r6RdcihYrnqjVO5KPiDkw71mK75qUzT
0tutCIUkLlZtrQ/CoWVSILTgsCUxTlwMSHHmkz5BtDBpahbdudWG9sTjG5mEKYoE
k77ZV45HqFimVVd86zqzolr3KPBjBPVszlTeciS+P1xAXfE/TruXdiRsCbGw7phW
kzpjJu3VpDrhNKZI93VV5EOd6wchJq/bgczVbQRIZ76eyM6EL7rN/3x/FKnV7saa
qtpydzraEesGAPcB3Uv4CR1zXN9MEdUUo2o9jUryOm75LlZfdinxT2EFqw2NpY0=
=rQrl
-----END PGP SIGNATURE-----