← Back to team overview

qpdfview team mailing list archive

Re: Merging form field overlay before or after version 0.4.7?

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Arnaud,

Am 03.11.2013 17:42, schrieb Arnaud Schmittbuhl:
> Le Sun, 03 Nov 2013 16:11:08 +0100, Adam Reichold
> <adam.reichold@xxxxxxxxxxx> a écrit :
> 
>> because of the problems with adding a tab focus chain to form
>> fields, I have started working on the branch "formfield-overlay"
>> which try to redesign the interactive element overlays for form
>> fields and also for annotations.
>> 
>> This leads to two open points:
>> 
>> * Please consider grabbing the branch, building it and testing it
>> to determine whether the changes are actually for the better.
> 
> Yes, it is better! Writing in the physical frame of the form is
> more intuitive. Something weird: when filling a form or an
> annotation, I expect the right and left key to go to the next or
> last char, not to go one page forward or backward. This didn't
> happen with qpdfview 0.4.6.99~1361.

Thanks for trying it out.

The problem with the movement keys comes from the fact that the
annotation/form field widgets are not top-level pop-ups any more, but
part of the graphics scene and hence keyboard event need to be
propagated down to them by the document view which however wants to
react to the movement keys itself. So as a fix, I disabled those page
jumping movements when any overlay is active...

> 
>> * If it is considered useful, should this be merged for version
>> 0.4.7? IMHO, this is not so much a question of time, but rather
>> whether there should be so many changes in a point release...
>> Please feel free to voice your opinion on this list.
> 
> I am in favor of merging asap.
> 
> Cheers,
> 

Ok, that two votes for merging including myself. Let's wait if any one
else has something to say.

Best regards, Adam.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJSdowPAAoJEPSSjE3STU34daEH/3N/ADX/uGPfI2Cfcj0wS46a
jnKL5R+sH2Pwoetd314weyaSWuV8RwzgmMFIy8gPuJ+fMISnwUYXq7LIOdqLqY0e
E2Y5sME9ZDhs59A7WblJSnouhIrUszM/g2y4MNGwMx1hOLGi0PrD+PXX9EqIUSCZ
MbmdlSo8WKDcVSbY07zbrPBAC1778H+9C2jmFeqM5651LwaOe3Y4/aPc83qKNmrv
TFvr4YzOd8ZjiAZn5s6FmWmUlDSHrO0ng1hci7TDL/97Q6zePoYbNPAD0Twjk78P
+qJ6vFK8IuXIeo/EBn/7B+96+0Bm22PfFZx44N5+onmEd94o5U5Cihc+QxA7dNI=
=YAo+
-----END PGP SIGNATURE-----


References