← Back to team overview

registry team mailing list archive

[Bug 680297] [NEW] most swift daemons don't honor log_name

 

Public bug reported:

the PasteDeploy loadapp/global_conf magic in run_wsgi enables you to set
the log_name for each swift server independently.  'object-server' could
be 'object-server1' or whatever other name you need to suit your needs.

Most of the daemons give the name of the logger as a string literal when they call get_logger:
self.logger = get_logger(conf, 'object-updater')

In general swift_deamons will use the string literal configured in their
__init__ for the NamedLogger tag instead of the value you define in
their config section (or DEFAULT) with the log_name key.

The exceptions I can find are the account-reaper, and the db-replicator
subclasses.  They seem take advantage of the fact that readconf will add
a "log_name" key based on the "section_name" if it's not present in the
config dict already.  If the user sets log_name in the conf - it uses
it!

So most calls to utils.get_logger could probably safely drop the literal
name kwarg and trust the conf has one in it.

The only exception to that rule would be daemons that call readconf with
a section_name of None (AFAIK, only the stats stuff) - they really do
need to specify some sort of "default_name" when calling get_logger.  In
fact the readconf logic in  "not section_name" for getting log_name may
need it's own bug...

** Affects: swift
     Importance: Low
         Status: New

-- 
most swift daemons don't honor log_name
https://bugs.launchpad.net/bugs/680297
You received this bug notification because you are a member of Registry
Administrators, which is subscribed to OpenStack Object Storage (swift).



Follow ups

References