← Back to team overview

registry team mailing list archive

Re: [Merge] lp:~jaypipes/glance/teller-api into lp:glance

 

lgtm. One thing I'd note: 

* Delete seems like a Return-None-on-success-raise-on-failure kind of method. It appears that FilesystemBackend behaves this way; however, the SwiftBackend is returning the resp_body from Swift. In this sense, it's leaking implementation details. I think it would be better if the SwiftBackend implicitly returned None just like the FilesystemBackend.



-- 
https://code.launchpad.net/~jaypipes/glance/teller-api/+merge/42858
Your team Glance Core is requested to review the proposed merge of lp:~jaypipes/glance/teller-api into lp:glance.



Follow ups

References