rohc team mailing list archive

[Didier Barvaux <question273309@xxxxxxxxxxxxxxxxxxxxx>]

Question #273309 on rohc changed:
https://answers.launchpad.net/rohc/+question/273309

Didier Barvaux posted a new comment:
Hello Abyan,

> I found a solution that is declare another feedback buffer then rohc_buf_append_buf ()
> and then rohc_buf_pull() the new buffer to &rohc_packet at compress4() and send it to
> remote. I can see its working that way.
> Do you think its ok ?

It is ok only if you rohc_buf_push() the buffer by the length of the
feedback data after the call to rohc_compress4() succeeded.

> If I want to take each feedback_send buffer to same buffer for next decompress()
> I see a error "given feedback_send is not empty" So thats why I did used another
> buffer to collect all next feedbacks.

If you get that error, then you probably forgot to "pull" the buffer by
the length of the feedback data at steps 4, 7 and 10.

The solution you found works, however it might be a little less
performant than the one I propose. Yours performs extra copies of
feedback data. Note that it might well change nothing if that data is
small and you don't have that much feedback.

Regards,
Didier

-- 
You received this question notification because your team ROHC Team is
an answer contact for rohc.