savoirfairelinux-openerp team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review+ functional tests

Hello, 

Thanks for the port:

Not in diff but it would be nice to use explicit import in __init__.py

Pylint just warn me about this line:

assert len(sale_id) == 1, "Only 1 ID accepted, received %r" % ids

ids does not exist in default_get of sale.exception.confirm.

Except that It seems good to me.

I also tested module in a functional way is works fine.
-- 
https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0-sale-exceptions-migr/+merge/175571
Your team extra-addons-commiter is subscribed to branch lp:e-commerce-addons.