← Back to team overview

savoirfairelinux-openerp team mailing list archive

Re: lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-exceptions-migr into lp:e-commerce-addons

 

> Hello,
> 
> Thanks for the port:
> 
> Not in diff but it would be nice to use explicit import in __init__.py
> 
> Pylint just warn me about this line:
> 
> assert len(sale_id) == 1, "Only 1 ID accepted, received %r" % ids
> 
> ids does not exist in default_get of sale.exception.confirm.
> 

Thanks for the review.
I changed that.
-- 
https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0-sale-exceptions-migr/+merge/175571
Your team extra-addons-commiter is subscribed to branch lp:e-commerce-addons.


References