savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

To: Joao Alfredo Gama Batista <joao.gama@xxxxxxxxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Mon, 11 Nov 2013 13:02:38 -0000
In-reply-to: <20130911151536.21430.1918.launchpad@ackee.canonical.com>
Reply-to: mp+185082@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

Hi Joao,

In the on_change methods (l.124,135,144), I propose to add the "context=None" argument and propagate it to the calls (l.138,147). Thus, if someone want to use the context in a module extending yours, he will be able just be inheriting the views.

Apart that, LGTM
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies/+merge/185082
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies.

References

lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes
From: Joao Alfredo Gama Batista, 2013-09-11