savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: Joao Alfredo Gama Batista <joao.gama@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 15 Nov 2013 18:40:44 -0000
In-reply-to: <20131112195124.1289.38321.launchpad@ackee.canonical.com>
Reply-to: mp+194926@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hi El Hadji,

Thanks for your contribution. As for the review I have this 2 points that you can improve.

l.100.103.132: Even in 6.1 the osv is considered deprecated (osv.osv actually points to orm.Model) so for the import is better to use "from openerp.osv import orm, fields" and for the models it's better to inherit from orm.Model istead of osv.osv.

l.129.137: In 6.1 we don't need to instantiate the model after defining it.


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/experience/+merge/194926
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/experience.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1
From: eh.dem, 2013-11-12