savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Fri, 20 Dec 2013 14:12:00 -0000
In-reply-to: <20131112195124.1289.38321.launchpad@ackee.canonical.com>
Reply-to: mp+194926@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hi,

Thanks for the contrib. A few remarks:

 * Line 27-29 use from . import XY
 * From a security point of view, is the hr_user the right person to create and delete the hr.academic, hr.professionnal, hr.certification object ? I would may be suggest hr_manager instead for that while keeping hr_user the read right, what do you think ?

Regards,

Joël
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/experience/+merge/194926
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/experience.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1
From: eh.dem, 2013-11-12