savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access into lp:purchase-wkfl

To: Mathieu Benoit <mathben963@xxxxxxxxx>
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 07 May 2014 14:14:36 -0000
In-reply-to: <20140506205600.3221.31461.launchpad@ackee.canonical.com>
Reply-to: mp+218509@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

l.288 looks like you forgot to put anything in for group_id:id

purchase_profit_forecast/__openerp__.py: 
Manifest "license" key is missing
Deprecated Manifest key ('active')
Deprecated Manifest key ('certificate')

Flake8:
report/analytic.py:3:1: E302 expected 2 blank lines, found 1
report/analytic.py:10:80: E501 line too long (80 > 79 characters)
report/purchase.py:4:1: E302 expected 2 blank lines, found 1
report/purchase.py:38:5: E303 too many blank lines (2)
report/purchase.py:41:9: F841 local variable 'result_context' is assigned to but never used
report/purchase.py:54:1: W391 blank line at end of file

Copyright dates are wrong

No .pot file
No unittests
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access/+merge/218509
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access.