savoirfairelinux-openerp team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review, pep8

l.112,464,2878 You can remove these empty files

Flake8
delivery_editable_dates/__openerp__.py:22:1: O603 Manifest "license" key is missing
delivery_editable_dates/__openerp__.py:28:5: O600 Warning unknown Manifest key ('caterogy')
delivery_editable_dates/__openerp__.py:38:5: O600 Warning unknown Manifest key ('active')

landed_cost_per_pallet/__openerp__.py:25:1: O603 Manifest "license" key is missing
landed_cost_per_pallet/__openerp__.py:51:5: O600 Warning unknown Manifest key ('active')
landed_cost_per_pallet/purchase.py:25:1: E302 expected 2 blank lines, found 1
landed_cost_per_pallet/purchase.py:117:55: E231 missing whitespace after ','
landed_cost_per_pallet/purchase.py:117:81: E231 missing whitespace after ','

pallet_delivery/__openerp__.py:25:1: O603 Manifest "license" key is missing
pallet_delivery/__openerp__.py:34:33: W291 trailing whitespace
pallet_delivery/__openerp__.py:57:5: O600 Warning unknown Manifest key ('active')
pallet_delivery/stock.py:26:1: E302 expected 2 blank lines, found 1
pallet_delivery/stock.py:70:23: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:96:9: F841 local variable 'pallet_ids' is assigned to but never used
pallet_delivery/stock.py:122:25: E126 continuation line over-indented for hanging indent
pallet_delivery/stock.py:185:1: W293 blank line contains whitespace
pallet_delivery/stock.py:210:32: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:213:39: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:228:28: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:236:21: E126 continuation line over-indented for hanging indent
pallet_delivery/stock.py:246:25: E126 continuation line over-indented for hanging indent
pallet_delivery/stock.py:271:13: E123 closing bracket does not match indentation of opening bracket's line

purchase_lot_tracking/__openerp__.py:25:1: O603 Manifest "license" key is missing
purchase_lot_tracking/__openerp__.py:38:48: W291 trailing whitespace
purchase_lot_tracking/__openerp__.py:51:5: O600 Warning unknown Manifest key ('active')
purchase_lot_tracking/account.py:23:1: F401 'dp' imported but unused
purchase_lot_tracking/account.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/account.py:48:21: E265 block comment should start with '# '

purchase_lot_tracking/account.py:23:1: F401 'dp' imported but unused
purchase_lot_tracking/account.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/account.py:48:21: E265 block comment should start with '# '
purchase_lot_tracking/product.py:24:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/product.py:35:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/purchase.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/purchase.py:51:65: W291 trailing whitespace
purchase_lot_tracking/purchase.py:52:49: E128 continuation line under-indented for visual indent
purchase_lot_tracking/purchase.py:53:49: E128 continuation line under-indented for visual indent
purchase_lot_tracking/purchase.py:54:49: E128 continuation line under-indented for visual indent
purchase_lot_tracking/purchase.py:55:75: E202 whitespace before '}'
purchase_lot_tracking/purchase.py:65:45: E127 continuation line over-indented for visual indent
purchase_lot_tracking/purchase.py:68:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:69:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:70:5: E303 too many blank lines (2)
purchase_lot_tracking/purchase.py:81:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:85:29: E222 multiple spaces after operator
purchase_lot_tracking/purchase.py:106:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:110:5: E303 too many blank lines (2)
purchase_lot_tracking/purchase.py:119:93: W291 trailing whitespace
purchase_lot_tracking/purchase.py:122:21: E126 continuation line over-indented for hanging indent
purchase_lot_tracking/purchase.py:124:24: W291 trailing whitespace
purchase_lot_tracking/purchase.py:133:25: E126 continuation line over-indented for hanging indent
purchase_lot_tracking/purchase.py:145:9: F841 local variable 'pick_id' is assigned to but never used
purchase_lot_tracking/purchase.py:151:17: E126 continuation line over-indented for hanging indent
purchase_lot_tracking/purchase.py:151:39: E231 missing whitespace after ','
purchase_lot_tracking/purchase.py:157:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:160:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:175:64: W291 trailing whitespace
purchase_lot_tracking/purchase.py:177:32: E201 whitespace after '{'
purchase_lot_tracking/purchase.py:177:54: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:177:67: E202 whitespace before '}'
purchase_lot_tracking/purchase.py:188:25: W291 trailing whitespace
purchase_lot_tracking/purchase.py:199:73: W291 trailing whitespace
purchase_lot_tracking/purchase.py:207:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:217:56: W291 trailing whitespace
purchase_lot_tracking/purchase.py:218:34: W291 trailing whitespace
purchase_lot_tracking/purchase.py:219:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:220:31: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:221:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:222:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:223:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:226:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:228:22: W291 trailing whitespace
purchase_lot_tracking/purchase.py:230:78: W291 trailing whitespace
purchase_lot_tracking/purchase.py:232:34: W291 trailing whitespace
purchase_lot_tracking/purchase.py:233:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:234:31: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:235:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:236:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:237:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:238:37: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:242:78: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:22:1: F401 'fields' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:22:1: F401 'orm' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:22:1: F401 'osv' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:23:1: F401 'netsvc' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:24:1: F401 'dp' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:26:1: F401 'datetime' imported but unused
purchase_lot_tracking/purchase_lot_tracking.py:31:1: E265 block comment should start with '# '
purchase_lot_tracking/purchase_lot_tracking.py:31:1: E303 too many blank lines (4)
purchase_lot_tracking/purchase_lot_tracking.py:38:26: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:42:36: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:44:16: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:47:43: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:52:2: W291 trailing whitespace
purchase_lot_tracking/purchase_lot_tracking.py:57:1: E265 block comment should start with '# '
purchase_lot_tracking/purchase_lot_tracking.py:64:1: E303 too many blank lines (3)
purchase_lot_tracking/purchase_lot_tracking.py:72:11: W291 trailing whitespace
purchase_lot_tracking/sale.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/sale.py:40:1: W293 blank line contains whitespace
purchase_lot_tracking/sale.py:54:1: W293 blank line contains whitespace
purchase_lot_tracking/sale.py:65:1: W293 blank line contains whitespace
purchase_lot_tracking/stock.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/stock.py:55:38: E231 missing whitespace after ','
purchase_lot_tracking/stock.py:85:1: W293 blank line contains whitespace
purchase_lot_tracking/stock.py:91:53: E128 continuation line under-indented for visual indent
purchase_lot_tracking/stock.py:118:1: W293 blank line contains whitespace
purchase_lot_tracking/stock.py:134:25: E126 continuation line over-indented for hanging indent
purchase_lot_tracking/stock.py:137:1: W293 blank line contains whitespace
purchase_lot_tracking/wizard/stock_partial_picking.py:1:24: W291 trailing whitespace
purchase_lot_tracking/wizard/stock_partial_picking.py:22:1: F401 'time' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:23:1: F401 'etree' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:24:1: F401 'fields' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:24:36: W291 trailing whitespace
purchase_lot_tracking/wizard/stock_partial_picking.py:25:1: F401 'DEFAULT_SERVER_DATETIME_FORMAT' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:26:1: F401 'float_compare' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:27:1: F401 'dp' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:28:1: F401 '_' imported but unused
purchase_lot_tracking/wizard/stock_partial_picking.py:30:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/wizard/stock_partial_picking.py:36:97: E712 comparison to True should be 'if cond is True:' or 'if cond:'
purchase_lot_tracking/wizard/stock_partial_picking.py:37:17: E125 continuation line with same indent as next logical line
purchase_lot_tracking/wizard/stock_partial_picking.py:40:19: W291 trailing whitespace
purchase_lot_tracking/wizard/stock_partial_picking.py:42:13: E221 multiple spaces before operator
purchase_lot_tracking/wizard/stock_partial_picking.py:53:1: W391 blank line at end of file
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access/+merge/218508
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access.