← Back to team overview

schooltool-developers team mailing list archive

Intervention fixes

 

Hey Justas,

I saw your intervention comments from Friday, so I fixed the two
issues and pushed to trunk:

1) The Intervention tab rendered even if there was no current term.
2) The Done links didn't get the user back to the inbox.

I wanted to make sure you knew I addressed those so that you didn't
waste your own time doing it.  One thing you could address is the
no_current_term.html view for all contexts (*).  There are many cases
in both the gradebook and the intervention where a view realizes that
there is no current term and redirects to whatever context it is +
'/no_current_term.html' rather than reach a dead end where only a
program exception is the result.  I didn't code a flourish version yet
because I thought we may have a new better place to redirect in these
cases.  Keep in mind that even if we are smart enough to hide tabs and
other links when there is no current term, that doesn't stop the user
from typing the url in themselves.  Please grep the cases where I
redirect to no_current_term.html and think about what we should do
there.

See you at the meeting,
Alan