schooltool-developers team mailing list archive

[Tom Hoffman <tom.hoffman@xxxxxxxxx>]

What about the style change?

---Tom

On Thu, Jun 21, 2012 at 9:01 PM, Ignas Mikalajunas <ignas@xxxxxx> wrote:
> No the change is not an accident, it was requested by me. The problem with
> conversion to list was, that sometimes it is not a list or a btree so
> expanding an sql table of 10k items into a list just to filter some out is
> very inefficient especially, if there is nothing to filter out.
>
> So this is an important performance optimization for the guys in philippines
> who are using combined sql + zodb tables.
>
> I don't think it is a good idea to rely on "omit" converting result into a
> list anyway, unles you want to rename it to "omit_and_convert_to_list" :D
>
> Ignas
>
>
> On Thu, Jun 21, 2012 at 11:02 PM, Douglas Cerna <douglascerna@xxxxxxxxx>
> wrote:
>>
>> Gediminas:
>>
>> The section_locations.txt stest made me realize that the ommited_items
>> check added in revision 3423 breaks the /resources view (and probably
>> others). Those ommit methods should return lists, or you'll get a permission
>> error on the btree. I fixed them in revision 3425.
>>
>> The expand_container change made relationships views to use the whole
>> width, which looks weird to me in some cases:
>>
>> http://img36.imageshack.us/img36/8021/pantallazodel2012062113.png
>> http://img843.imageshack.us/img843/8021/pantallazodel2012062113.png
>>
>> Was this style change an accident?
>>
>> Douglas
>>
>> "... allí­ es cuando te das cuenta que las cosas malas pueden resultar
>> bastante buenas..." - Lionel Messi
>>
>> Por favor, evite enviarme adjuntos de Word, Excel o PowerPoint.
>> Vea http://www.gnu.org/philosophy/no-word-attachments.es.html
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~schooltool-developers
>> Post to     : schooltool-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~schooltool-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~schooltool-developers
> Post to     : schooltool-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~schooltool-developers
> More help   : https://help.launchpad.net/ListHelp
>