← Back to team overview

software-store-developers team mailing list archive

Re: Acceptance Criteria and Software Center

 

Hi all,

Sorry for the long period of absence and silence - my work has been
taking up all of my time and for the foreseeable future I can't see
much changing so it's unlikely I'll be writing much code for at least
a month or so. Keen to get back into asap though!

Congrats to everyone on achieving some great progress with the release
of USC in Oneiric.

Re Gary's policy, it all makes sense and will be a good control
mechanism for us to ensure quality.
Having written a few changes for rnr-server and experienced a more
stringent merge proposal process I envisage USC moving more towards
that type of thing, where relevant unit tests and written and passing
in order for a peer review to be approved. Something we don't
necessarily do when proposing merges for USC is write test cases and
run all tests to ensure we haven't regressed anything. When I'm trying
to get changes written I hate nothing more than fixing regressed tests
and essentially it means a longer lifecycle time and potentially more
re-work until a change gets merged but the quality of trunk as a
result of the process should be higher result (and the number of bug
reports for anyone using development releases should decrease)

cheers
Aaron

On 11/9/11, Michael Nelson <michael.nelson@xxxxxxxxxxxxx> wrote:
> On Tue, Nov 8, 2011 at 4:50 PM, Michael Vogt <mvo@xxxxxxxxxx> wrote:
>> On Mon, Nov 07, 2011 at 08:08:19PM -0500, Gary Lasker wrote:
>>> Hello Software Center devs!
>> Hey Gary,
>>
>> [..]
>>> And make no mistake, the idea here is to increase development velocity
>>> by increasing code quality and knowledge sharing, etc. It is most
>>> definitely *not* intended to slow things down with heavyweight
>>> processes. In fact, the changes for our team will likely be fairly
>>> minimal as we already have all of the important pieces in place in our
>>> process today (code reviews, automatic unit tests, etc.).
>>>
>>> Further, we, as a team, have the freedom to implement the processes in
>>> such a way as we see fit to make them work best for *our team*. The idea
>>> is to *increase* the enjoyment and satisfaction we all get from our work
>>> on Software Center. If at any point anyone feels like the opposite is
>>> happening, let's talk about it right away and fix it.
>> [..]
>>
>> Thanks for this great summary of the changes. I can only second what
>> you wrote, I want this to be something that we enjoy doing and were we
>> feel that folllowing these principals of peer review and good test
>> coverage gives us better code as a result (and better code leads to
>> more fun, right ,)
>>
>
> On that note, read jml's "How to feel better (or, some tips on
> refactoring)":
>
> http://code.mumak.net/2011/11/how-to-feel-better-or-some-tips-on.html
>
> which is not strictly about writing tests, but how to continuously
> improve your code so you can enjoy programming more :)
>
> --
> Michael Nelson
> Canonical Ltd.
> +49 176 491 53481 (mob)
> michael.nelson@xxxxxxxxxxxxx
> IRC nick: noodles (noodles775 on Freenode)
> Ubuntu - Linux for human beings | www.ubuntu.com | www.canonical.com
>
> _______________________________________________
> Mailing list: https://launchpad.net/~software-store-developers
> Post to     : software-store-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~software-store-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References