structbiol team mailing list archive

[Morten Kjeldgaard <mok@xxxxxxxxxx>]

On 2010-12-15 02:29, Tim Fenn wrote:
> Here are the patches following bzr send.  (can we just bzr push to the
> main branch?)
> 
> -Tim
> 
> On Tue, 14 Dec 2010 15:44:30 -0800
> Tim Fenn <fenn@xxxxxxxxxxxx> wrote:
> 
>> I pushed a few changes to gpp4, mmdb and ssm to address a few things:
>>
>> - gpp4 patched for support for s390x arch
>> - added pkgconfig support to mmdb
>> - standardized ssm pkgconfig file and use pkgconfig to find mmdb
>>
>> I hope these patches are OK, feel free to tweak them as necessary.
>> Maybe the versioning can get updated to the CCP4 standard and make
>> the new packages available as downloads?

Great, thanks Tim!

At the moment, you are in fact able to push changes directly on the bzr
branch of MMDB and SSM, because the two branches lp:mmdb and lp:ssm are
owned by the structbiol team. The gpp4 branch lp:gpp4 is currently not,
because it was created before the team existed.

Would you like to test that you can push the changes to these branches, or
should I apply the patches you sent?

The way to propagate changes to a project that you don't own and can't push
to is to create a branch of the project on launchpad, and push your changes
to that branch. You can then request the project owner to merge your branch
into the main branch.

Would you like to try this? Or should I just:

a) transfer the branch ownership like mmdb and you push the changes yourself, or
b) apply the patch you sent?

There are some significant recent changes on the MMDB code. All patches from
the Coot dependencies distribution (1.23.2) have now been merged into the
launchpad MMDB project, and the code was released as version 1.23.2.1. In
addition, there are some quite significant bug-fixes. Most are latent bugs,
where variables are initialized inside a conditional statement, but
referenced outside. These bugs will hit only if the conditional is not
fullfilled (which may be never). The most serious bug prevents the rwbrook
Fortran bindings from ever dealing with atomic displacement tensors in
fractional form, see [0].

Cheers,
Morten

[0] <https://bugs.launchpad.net/mmdb/+bug/684897>

-- 
Morten Kjeldgaard, asc. professor, MSc, PhD
BiRC - Bioinformatics Research Center, Aarhus University
C.F. Møllers Alle, Building 1110, DK-8000 Aarhus C, Denmark.
Lab +45 8942 3130 * Fax +45 8942 3077 * Home +45 8618 8180