structbiol team mailing list archive

[Tim Fenn <fenn@xxxxxxxxxxxx>]

On Wed, 15 Dec 2010 10:09:19 +0100
Morten Kjeldgaard <mok@xxxxxxxxxx> wrote:

> 
> At the moment, you are in fact able to push changes directly on the
> bzr branch of MMDB and SSM, because the two branches lp:mmdb and
> lp:ssm are owned by the structbiol team. The gpp4 branch lp:gpp4 is
> currently not, because it was created before the team existed.
> 

OK - I'm just not sure what the proper format for bzr push to use?  I
tried one or two things without success, could you give me a hint?

> 
> The way to propagate changes to a project that you don't own and
> can't push to is to create a branch of the project on launchpad, and
> push your changes to that branch. You can then request the project
> owner to merge your branch into the main branch.
> 

I did that with all three, just for practice.  >.<

> 
> There are some significant recent changes on the MMDB code. All
> patches from the Coot dependencies distribution (1.23.2) have now
> been merged into the launchpad MMDB project, and the code was
> released as version 1.23.2.1. In addition, there are some quite
> significant bug-fixes. Most are latent bugs, where variables are
> initialized inside a conditional statement, but referenced outside.
> These bugs will hit only if the conditional is not fullfilled (which
> may be never). The most serious bug prevents the rwbrook Fortran
> bindings from ever dealing with atomic displacement tensors in
> fractional form, see [0].
> 

Ah, OK - I was wondering about the odd versioning there.  Which brings
up another point: we're following upstream, but adding fixes/edits to
the code - maybe we should stick with the upstream version
numbering/files and include our changes as a patch set that can be
applied before building, to avoid confusion and potential
conflicts/problems?  The patches could be sent upstream.  Or we could
have our own, independent naming/versioning scheme, (like what was done
with gpp4 - for example, gmmdb and gssm or something) - that way people
who download the code know/realize its not the "official" ccp4 stuff.

-Tim

-- 
---------------------------------------------------------

        Tim Fenn
        fenn@xxxxxxxxxxxx
        Stanford University, School of Medicine
        James H. Clark Center
        318 Campus Drive, Room E300
        Stanford, CA  94305-5432
        Phone:  (650) 736-1714
        FAX:  (650) 736-1961

---------------------------------------------------------