subunit-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Sun, 2009-06-07 at 02:33 +0200, Jelmer Vernooij wrote:
> 
> > > I'd like to be able to report that fact to the user.
> 
> > How about 
> > if [ -z "$RUN_TDB" ]; then
> >     tdb/suite | subunit-filter --add-prefix tdb
> > else
> >     echo test suite-tdb
> >     echo skip suite-tdb
> > fi
> 
> That doesn't imply afaik that all of the tests that start with
> suite-tdb are
> skipped as well. Is there a defined hierarchy of tests in subunit?

No, but for reporting it to your users it seems clear. Maybe I don't
understand what you want your users to see.

> One of the things I like about subunit is that it's pretty well
> readable without a prettifier, is simple and doesn't require anything
> in the 
> test runner other than following a few conventions about output. 
> Subunit is not a different way of doing test results to me, it's
> something on 
> top of what we already have that allows us to extract more information
> from
> the test results.

Sure. Human readable is a key goal :).

> So, for now it seems to make most sense to keep these extensions
> specific to Samba. I've tried your suggestion about having a Subunit
> filter that adds prefixes and that seems to work well so I'm happy
> with the existing possibilities in the subunit protocol and the
> functionality 
> in the subunit tools for now.

I'd like to get that added to the subunit-filter command, as it seems
generally useful.

> I now also have a diff-subunit command, written in Perl that I hope to
> land in Samba as part of "make test" next week. I'll submit this
> upstream as well, with a version of Subunit.pm that has all the
> Samba-specific commands stripped out.

It may raise some interesting questions when people install 'subunit' to
get python-subunit and perl-subunit at the same time as hard
dependencies ;)... cross that when it happens.

-Rob

Attachment: signature.asc
Description: This is a digitally signed message part