← Back to team overview

syncany-team team mailing list archive

Re: FindBugs Analysis


Hallo Jason,

I think that's a great thing to do. I just ran a test myself and I
think this a great tool. In my opinion, the test on the Syncany code
didn't look too bad. There are a few things I should probably change
or update, but nothing serious.

Regarding the TTTDChunker: this one is experimental, so there is no
need to worry :-) I'll succeed the fixed-chunking mechanism. It
implements the Two Thresholds Two Divisors Algorithm [1].

By the way: feel free to fix some bugs yourself :-)


On Sun, May 29, 2011 at 11:42 AM, Jason Irwin <jasonirwin73@xxxxxxxxx> wrote:
> Out of curiosity, I ran a FindBugs analysis of the Syncany code this
> morning.  FindBugs is a static code analysis tool and I personally find it
> fairly useful for trapping “silly” bugs before they get too far.  For
> example, org.syncany.index.TTTDChunker.createChecjsum(File file) will throw
> an NullPointerException when invoked (“chunk” is always null).
> Although it does sometimes give spurious results (for example, it complains
> that there is a String format issue in
> org.syncany.config.Cache.createTempFile(String name) but the code looks
> fine).
> Do people feel that this will be useful?
> And does anyone have advice on where someone new to the code can get started
> (design docs etc).  Hmm...I’d best get my Launchpad account fully set-up
> too!
> J.
> --
> Mailing list: https://launchpad.net/~syncany-team
> Post to     : syncany-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~syncany-team
> More help   : https://help.launchpad.net/ListHelp

Follow ups