testtools-dev team mailing list archive

[Māris Fogels <mfogels@xxxxxxxxx>]

Review: Approve
Not a developer, but why did you use getatter() in Mismatch.get_details()?  It looks like the constructor guarantees that the object always has a valid ._details attribute.

I think the changes look good.


Maris
-- 
https://code.launchpad.net/~jml/testtools/basic-mismatch/+merge/32872
Your team testtools developers is requested to review the proposed merge of lp:~jml/testtools/basic-mismatch into lp:testtools.