testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

On Tue, Aug 17, 2010 at 3:41 PM, Māris Fogels <mfogels@xxxxxxxxx> wrote:
> Review: Approve
> Not a developer, but why did you use getatter() in Mismatch.get_details()?  It looks like the constructor guarantees that the object always has a valid ._details attribute.

Not all subclasses upcall. I could change the subclasses in
testtools.matchers, but I can't change the subclasses that other
people have made elsewhere.
-- 
https://code.launchpad.net/~jml/testtools/basic-mismatch/+merge/32872
Your team testtools developers is requested to review the proposed merge of lp:~jml/testtools/basic-mismatch into lp:testtools.