testtools-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Sun, Sep 12, 2010 at 8:55 PM, Jonathan Lange <jml@xxxxxxxxxxxxx> wrote:
> Quick thoughts.
>
>  * What's up with the diff to the NEWS file?

The most recent section had indented lists, inconsistent with the
rest; it was a driveby fix. I have memories of this affecting the ReST
output of it too.

>  * How does this interact with bug 593190?

Neither better or worse: we print the matchee as often as we did
before, no more, no less.

>  * Why "referenced" and "actual" when the code uses "expected" and "observed"? Although the former are technically correct, I don't see them as being substantially more helpful than the previous "a" and "b".

Well, two things the a and b annoyed me from the get-go, and, more
importantly, in matchers we do have a semantic difference between left
and right, so I don't think we should obscure that.

-Rob
-- 
https://code.launchpad.net/~lifeless/testtools/matchers/+merge/35212
Your team testtools developers is requested to review the proposed merge of lp:~lifeless/testtools/matchers into lp:testtools.