testtools-dev team mailing list archive

["Martin \[gz\]" <gzlist@xxxxxxxxxxxxxx>]

Martin [gz] has proposed merging lp:~gz/testtools/fix_test_outcome_Extended_py27_no_reason_666151 into lp:testtools.

Requested reviews:
  testtools developers (testtools-dev)
Related bugs:
  #666151 Tests of 0.9.7 fail with Python 3.1
  https://bugs.launchpad.net/bugs/666151


Simple error that slipped in when Robert was merging my test skipped reason branch. The Content object created needs bytes content, but was getting unicode text on Python 3.
-- 
https://code.launchpad.net/~gz/testtools/fix_test_outcome_Extended_py27_no_reason_666151/+merge/39292
Your team testtools developers is requested to review the proposed merge of lp:~gz/testtools/fix_test_outcome_Extended_py27_no_reason_666151 into lp:testtools.

=== modified file 'testtools/tests/test_testresult.py'
--- testtools/tests/test_testresult.py	2010-10-21 13:09:35 +0000
+++ testtools/tests/test_testresult.py	2010-10-25 16:44:47 +0000
@@ -813,7 +813,7 @@
     def test_outcome_Extended_py27_no_reason(self):
         self.make_27_result()
         self.check_outcome_details_to_arg(self.outcome, 'foo',
-            {'reason': Content(UTF8_TEXT, lambda:['foo'])})
+            {'reason': Content(UTF8_TEXT, lambda:[_b('foo')])})
 
     def test_outcome_Extended_pyextended(self):
         self.make_extended_result()