testtools-dev team mailing list archive

[Jelmer Vernooij <684071@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

 affects testtools

twisted.internet.base.DelayedCall has different behaviour depending
whether or not debug was specified to its constructor. It will set
self.creator to traceback.format_stack().

Later on, in its __str__ it uses the debug attribute to determine
whether or not to add a traceback to the output - a traceback which is
not available in case testtools monkey patched debug to be true.

Btw, apart from this issue the debug code was really useful in tracking
down a bug in the builddmanager yesterday. Thanks for writing it.

Cheers,

jelmer

** Affects: testtools
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of testtools
developers, which is subscribed to testtools.
https://bugs.launchpad.net/bugs/684071

Title:
  monkey patching 'debug' breaks twisted.internet.base.DelayedCall

Status in testtools:
  New

Bug description:
   affects testtools

twisted.internet.base.DelayedCall has different behaviour depending
whether or not debug was specified to its constructor. It will set
self.creator to traceback.format_stack().

Later on, in its __str__ it uses the debug attribute to determine
whether or not to add a traceback to the output - a traceback which is
not available in case testtools monkey patched debug to be true.

Btw, apart from this issue the debug code was really useful in tracking
down a bug in the builddmanager yesterday. Thanks for writing it.

Cheers,

jelmer