← Back to team overview

testtools-dev team mailing list archive

Re: [Merge] lp:~rvb/testtools/testtools-contains-all into lp:testtools

 

> Raphaël, could you please update the tests to not rely on string containment
> -- I think that would be clearer.  e.g.
> 
>  +    matches_matches = [['foo', 'bar'], ['foo', 'z', 'bar'], ['bar', 'foo']]

Sure, I've refactored matches_matches and matches_mismatches in TestContainsAllInterface to not rely on string containment.

> Also if you could add another sentence to the class docstring using the word
> 'subset' somewhere that'd be great.

Done.  Feel free to suggest something else for the docstring if the one I put doesn't suit you.
-- 
https://code.launchpad.net/~rvb/testtools/testtools-contains-all/+merge/104065
Your team testtools developers is subscribed to branch lp:testtools.


References