← Back to team overview

tomdroid-dev team mailing list archive

Re: Patch: lifecycle management and content provider


Thanks for the patch!

I tried to look at it quickly and I am overwhelmed by the size right now
(not a lot of time on my hands). I'll definitely take the time to look at it
and will split it into cohesive chunks, test and merge.

I'll keep you posted on my progress. But please be patient, I just switched
jobs so I'll be focusing on that new job a lot.

Have a nice day!

On Sat, Jun 27, 2009 at 5:29 PM, pjv <ezelspinguin@xxxxxxxxx> wrote:

> Hi,
> I intended to look at the lifecycle management in Tomdroid 0.2 (or
> actually the trunk). It all seems fine now. Except that some the power
> of the ContentProvider is not used currently (as is indicated with TODOs
> in the code).
> The appended patch (or you can merge the branch on launchpad) contains
> various changes:
> 1) Remove 'close' menu item, as it is not necessary with Android, use
> the 'back' key instead.
> 2) Substitute OI About as about dialog. In eclipse you need to have a
> project with the OI About sourcecode open now. If this is a problem, we
> can just copy the few constants that are shared this way into Tomdroid.
> 3) Use a Service to fill the ContentProvider in onCreate() (but
> threaded) and let Android fill the list from the ContentProvider itself.
> Notes are not removed at this point. Also, some other thread mechanisms
> can likely be removed.
> 4) Slight UI changes. At least I think this puts Tomdroid more in line
> with other Android software.
> It all seems to work, but is not fully tested. Also I moved many pieces
> of code around, without making changes to the many remarks and TODOs in
> the code, so some refactoring and sifting through is probably in order.
> Let me know if you have any questions. I hope a new version can
> eventually be released with these changes.
> Regards,
> --
> pjv
> _______________________________________________
> Mailing list: https://launchpad.net/~tomdroid-dev<https://launchpad.net/%7Etomdroid-dev>
> Post to     : tomdroid-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~tomdroid-dev<https://launchpad.net/%7Etomdroid-dev>
> More help   : https://help.launchpad.net/ListHelp

Olivier Bilodeau <olivier@xxxxxxxxxxxxxxxxx>