← Back to team overview

touch-packages team mailing list archive

[Bug 1351345] [NEW] AuthLogger needlessly calls abort for qFatal messages

 

Public bug reported:

In the AuthLogger class's custom message handler, we are calling abort()
if the message type is fatal. This is not needed, as Qt internally will
call abort in the event of fatal messages, after calling our custom
message handler. This results in the crash files generated by the abort
being called, being incorrectly attributed to an issue in ubuntuone-
credentials, when the code calling qFatal() to log a fatal error is the
actual culprit.

** Affects: ubuntuone-credentials (Ubuntu)
     Importance: High
     Assignee: Rodney Dawes (dobey)
         Status: In Progress


** Tags: rtm14

** Description changed:

  In the AuthLogger class's custom message handler, we are calling abort()
  if the message type is fatal. This is not needed, as Qt internally will
  call abort in the event of fatal messages, after calling our custom
- message handler.
+ message handler. This results in the crash files generated by the abort
+ being called, being incorrectly attributed to an issue in ubuntuone-
+ credentials, when the code calling qFatal() to log a fatal error is the
+ actual culprit.

** Changed in: ubuntuone-credentials (Ubuntu)
     Assignee: (unassigned) => Rodney Dawes (dobey)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntuone-credentials in
Ubuntu.
https://bugs.launchpad.net/bugs/1351345

Title:
  AuthLogger needlessly calls abort for qFatal messages

Status in “ubuntuone-credentials” package in Ubuntu:
  In Progress

Bug description:
  In the AuthLogger class's custom message handler, we are calling
  abort() if the message type is fatal. This is not needed, as Qt
  internally will call abort in the event of fatal messages, after
  calling our custom message handler. This results in the crash files
  generated by the abort being called, being incorrectly attributed to
  an issue in ubuntuone-credentials, when the code calling qFatal() to
  log a fatal error is the actual culprit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntuone-credentials/+bug/1351345/+subscriptions


Follow ups

References