touch-packages team mailing list archive

[Aron Xu <1356222@xxxxxxxxxxxxxxxxxx>]

On Thu, Aug 14, 2014 at 12:21 AM, Didier Roche <didrocks@xxxxxxxxxx> wrote:
> -> brise
> * BLOCKER: kyotocabinet-utils build-deps is in universe. Please add that one to the MIR if it matches the MIR criterias or drop those.

Added.

> * BLOCKER: COPYING is GPL3. Some files are LGPL-2+, GPL-2+ and those
requires the license to be shipped in the upstream source. Please make
upstream to ship those in their tarball.

https://code.google.com/p/rimeime/issues/detail?id=644

> * MINOR/NEED INFO: any idea why the source has a priority extra?
>

At the initial packaging time this engine isn't so popular and the
code does not build on architectures except x86 ones, so it's
considered to suit to a lower priority. Changed in git:
http://anonscm.debian.org/cgit/pkg-ime/brise.git/commit/?id=b56d9e588b5b654bae829b14b3ffa37186d7b266

> -------
> -> fcitx:
> * BLOCKER: presagege is missing as a build-dep, do you mind either not building with it (optional dep) or add it and check it matches the MIR criterias?

Added and checked presage and libtinyxml (b-d/dep of presage) to MIR.
Live without presage is doable, but better avoid that.

> * BLOCKER: there are some LGPL files and no COPYING.LGPL file, please
ship it in the upstream tarball.

https://github.com/fcitx/fcitx/issues/169

I can commit but usually don't do that directly.

> * NEED INFO/FIXING: fcitx-libs-gclient (and a lot of other binary packages): package-name-doesnt-match-sonames. Do you know why we don't follow upstream soname? They are at 0, so package name should be fcitx-libs-gclient0 as it's a public library. Otherwise, it should be in a private path.
> * NEED FIXING: I noted the remark on fcitx-libs in debian/README.source, and even if I'm not a fan of the current approach of the 3 libraries in the same package, I think we can live with it. However, we need to have a soname in the end, so that the binary package name can be bumped for any soname breaking in one of the 3 libraries (as some rdepends are not frmothe same source pacakage, like kde-config-fcitx or youker-assistant).

The reason is that we have done this for fcitx-libs before, so that
following the same convention. We plan to change that when next major
release of Fcitx is out, and for now the API/ABI is pretty stable for
a while so there is no real pressure to rush for that.

> * NEED FIXING: even if it's wrap under a sh call, better to be
coherent and get the script executable: W: fcitx-bin: script-not-
executable usr/share/fcitx/data/env_setup.sh

This is intentional done by upstream, so after some communication I
don't see strong reason to maintain a diff.

> * NEED FIXING: debian/copyright:
> - fcitx-4.2.8.4/src/frontend/qt/keyserver_x11.h: missing copyright to 2004 Jaroslaw Staniek <js@xxxxxxxx>
> - fcitx-4.2.8.4/src/frontend/xim/lib/XimProto.h: missing the copyright (1992, 1993, 1994 by FUJITSU LIMITED)
> - src/ui/kimpanel/kimpanel.c. You set "Copyright: 2008-2010, Zealot.Hoi", but it misses "2010~2012 by CSSlayer *" (files: * doesn't cover it as it's overriden)
> - Copyright: 2003-2009, Troy D. Hanson     http://uthash.sourceforge.net => it's actually 2003-2010
> - Files: src/lib/fcitx-utils/qsort_r.c. Please mention the short name of the license "MIT/X11 (BSD like)"
> - fcitx-4.2.8.4/src/lib/fcitx-qt/fcitxqtkeysequencewidget.h and fcitx-4.2.8.4/src/lib/fcitx-qt/fcitxqtkeysequencewidget_p.h: GPL (v2 or later) LGPL (v2 or later)
>   Missing: 2007 Andreas Hartmetz <ahartmetz@xxxxxxxxx> / 2001, 2002 Ellis Whitehead <ellis@xxxxxxx>
> - fcitx-4.2.8.4/src/module/lua/luawrap.c/h, fcitx-4.2.8.4/src/module/lua/luamod.c/h:: GPL (v2 or later). [Copyright: 2012~2012 by xubin *] (needs mention)

http://anonscm.debian.org/cgit/pkg-
ime/fcitx.git/commit/?id=348b6dae534bb2d08e2f3728b345bb3ed18fa98a

> * MINOR: debian/patches/ubuntu-disable-fcitx-xkb.patch:
> do you mind using DEP3 for annotating the patch? (http://dep.debian.net/deps/dep3/)

That's a quick `quilt header -e`, I'll update it before next upload if
it does not get dropped (attente may don't need it now).

> * MINOR: I think you should add a head to debian/control (after you cp
the .in to the control file) to tell to not edit that file as
debian/rules, through gencontrol.mk is going to edit and sed it.

http://anonscm.debian.org/cgit/pkg-
ime/fcitx.git/commit/?id=7669d5769d0e5b7de4ce011a3a3031d82f8adab5

> * NEEDS INFO: I see that we are running the unit tests at build time.
Is there any integration tests that we can run, installing the various
modules? (like -anthy, -chewing… and so on…)

Nope, the testing is limited to some core functions of the framework
itself, and there is no usable testing facility for other modules in
Fcitx 4.8 series.

> -----
>
> -> fcitx-anthy:
> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control

It makes little sense to make sure all the modules are co-installable
since only one copy can be used, so that the work isn't actively
pushed. Changing:
http://anonscm.debian.org/cgit/pkg-ime/fcitx-anthy.git/commit/?id=0be99f31f8c8dc81afb09696d86c2095a01cc9ae

> * NEED FIXING: debian/copyright: doesn't contain any other copyright holder. Please fix it.
> For instance: src/factory.h: GPL (v2 or later)
>   [Copyright: 2004 Hiroyuki Ikezoe / 2004 Takuro Ashie / 2012 CSSlayer / 2004 James Su <suzhe@xxxxxxxxxxxxxxx>]
> src/imengine.cpp: GPL (v2 or later)
>   [Copyright: 2004 - 2005 Hiroyuki Ikezoe <poincare@xxxxxxxxxx> / 2012 CSSlayer / 2004 - 2005 Takuro Ashie <ashie@xxxxxxxxxx> / 2004 James Su <suzhe@xxxxxxxxxxxxxxx>]

http://anonscm.debian.org/cgit/pkg-ime/fcitx-anthy.git/commit/?id=5d5249cdf62b9a21b92ceedeeb4ef0d16f247619
http://anonscm.debian.org/cgit/pkg-ime/fcitx-anthy.git/commit/?id=d74a427fb6f53502d3c80e2b97d1b4925fe27669

> ------
> -> ficitx-cloudpinyin:
> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
cloudpinyin.git/commit/?id=f47d60ab904aba6029e631274c899fada1758d95

> * MINOR: debian/copyright:
> Copyright should be 2011-2012, not only 2011

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
cloudpinyin.git/commit/?id=52442b5c129411cf21c4b25887af980e8b54857b

> * NITPICK: typo in debian/control: "to retrive result candidates" -> retrieve
>

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
cloudpinyin.git/commit/?id=82eabd3d4ee8c06e5d903a3f7fffbc5cce43f615

> ------
> -> fcitx-configtool
> * BLOCKER: debian/copyright is not well-formated:
> line 5: missing Files: line.
> The License text should be in a separate stanza as well.

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
configtool.git/commit/?id=a948aa5caaf4c3cdc57bb51f642276bb6754e0ce

> * NITPICK: debian/copyright
> Depends: line for fcitx-config-gtk is too long, please wrap it.
>

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
configtool.git/commit/?id=a133111096e95794fa1d221012237c4e9082e104

> ------
> -> fcitx-googlepinyin
> * BLOCKER: same issue in debian/copyright

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
googlepinyin.git/commit/?id=a8dda275395884afaa59d47f69c6c5dbca4f2b78

> * BLOCKER: build-dep on libgooglepinyin0-dev which is in universe.
Please drop that plugin from the MIR or add the dependency after
checking it's suiting the MIR requirements.

Added and checked.

> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control
>

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
googlepinyin.git/commit/?id=7dee3104f9725637d42da95424b5fbf59ad9e120

> ------
> -> fcitx-hangul
> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
hangul.git/commit/?id=0d4418f3a35e1346f6c4461d3eb5d97016e4f002

> * NEEDS INFO: fcitx-hangul: hardening-no-stackprotector usr/lib/x86_64
-linux-gnu/fcitx/fcitx-hangul.so. Any way we can fix this? Not having
stackprotector leads the potentially code that can be attacked.

I don't see such problem, nor do lintian.d.o:
https://lintian.debian.org/full/pkg-ime-devel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx#fcitx-hangul

> * MINOR: debian/copyright:
> Copyright: 2012 CSSlayer <wengxt@xxxxxxxxx> -> should be 2010-2012
>

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
hangul.git/commit/?id=648c746466c92d6b9a86a5d4bcade691e57b2f86

> ------
> -> fcitx-m17n
> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
m17n.git/commit/?id=15108dfe41f329f4bb041ca96f2dbebda117ec24

> * MINOR: debian/copyright:
> missing   Copyright: 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald in im/keysymname.c
>

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
m17n.git/commit/?id=9d981e902b048bc3cdb74d94b15ab896ae8029da

> ------
> -> fcitx-qimpanel:
> * BLOCKER: there is no COPYING for GPL2 and GPL3. Both are needed to be shipped upstream.

https://github.com/lenky0401/fcitx-qimpanel/issues/26

> * NEEDS FIXING: the package is multi-arch and should be marked as such
in debian/control

I prefer not doing it at this moment because I need some time to
verify the behavior.

> * NEEDS INFO: I guess the autostart binary shouldn't be in usr/bin, but more in an exec path like libexec for instance.
>

Will talk with relevant people to see if we can move that.

> ------
> -> fcitx-qimpanel-configtool:
> * BLOCKER: there is no COPYING for GPL2 and GPL3. Both are needed to be shipped upstream. There is only an empty LICENSE file.
>

This package is merged to fcitx-qimpanel upstream for next release, so
there is no need to open an issue again.

> ------
> -> fcitx-qt5
> * BLOCKER: there is no COPYING for GPL2 nor LGPL2. Both are needed to be shipped upstream.

https://github.com/fcitx/fcitx-qt5/issues/4

> * NEEDS FIXING: fcitx-libs-qt5: package-name-doesnt-match-sonames
libfcitx-qt5-0. Please rename the binary package + add an override,
there is only one shared lib and it's better to follow debian packaging
convention for Qt libs.

As expained for fcitx-libs-gclient and fcitx-libs.

> * NEEDS FIXING:
> debian/copyright:
> missing src/keyserver_x11.h: LGPL (v2 or later)
>   [Copyright: 2001 Ellis Whitehead <ellis@xxxxxxx> / 2004 Jaroslaw Staniek <js@xxxxxxxx>]

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
hangul.git/commit/?id=648c746466c92d6b9a86a5d4bcade691e57b2f86

> * MINOR: it would be nice to have a .symbol file.
>

Will deal with it a bit later.

> ------
> -> fcitx-rime:
> * BLOCKER: COPYING is GPL2, so we can assume the only file is src/fcitx-rime.c is under that license. debian/copyright mention GPL3+. Needs to be fixed in accordance.

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
rime.git/commit/?id=2b0beb3d640500eb533b7fa0755a5c33c7182fc1

> * BLOCKER: build-deps on librime which is in universe. Please add that
one to the MIR if it matches the MIR criterias or drop that one.

Already in the report.

> * BLOCKER: this package doesn't build on armhf which is one of our
supported arch. It needs to be buildable on that arch (librime-data
can't be installed)

Need to retry the build, old librime does not build on that much
architectures so no librime-data, but current one does.

> * NEEDS FIXING: the package is multi-arch and should be marked as such
in debian/control

This makes little sense here, as librime-data isn't M-A'd, which is a
Depends of this package.

> * MINOR: The source in debian/copyright is fcitx one, not fcitx-rime
>

Upstream-Name shows fcitx-rime, and it's exactly maintained by fcitx
upstream. Actually it's quite normal that active modules get merged to
Fcitx's umbrella project, and Fcitx maintainers ensure APIs are synced
once there's any change.

> ------
> -> fcitx-sunpinyin:
> * BLOCKER: COPYING is GPL2 as the files from the project. debian/copyright mention GPL3+. Needs to be fixed in accordance.

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
sunpinyin.git/commit/?id=214a48b57b3104f96168f6dd794d2fc692e46cd6

> * BLOCKER: debian/copyright is not well-formated (same issue than in
fcitx-configtool)

http://anonscm.debian.org/cgit/pkg-ime/fcitx-
sunpinyin.git/commit/?id=bb05161922d11fb98ee21d6154e74d91bd5a2e54

> * NEEDS FIXING: the package is multi-arch and should be marked as such in debian/control
>

This makes little sense as sunpinyin-data isn't M-A ready, which is a
Depends of fcitx-sunpinyin.

> ------
> -> fcitx-table-extra:
> * BLOCKER: tables/scj6.txt is GPL3, there is no COPYING file mentionning GPL3. You need upstream to ship it.

https://github.com/fcitx/fcitx/issues/170

> * NEEDS FIXING:
> W: fcitx-table-cantonese: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-cantonese.png 48x48
> W: fcitx-table-stroke5: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-stroke5.png 48x48
> W: fcitx-table-zhengma: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/48x48/apps/fcitx-zhengma.png 64x64

Will get a patch for upstream soon and apply to Debian/Ubuntu.

> * NEEDS INFO: debian/rules:
> override_dh_install:
>     find . -name *.mo -delete
> why stripping the generated .mo file? They aren't shown anyway in any UI?

No, they are not shown atm.

>
> ------
> -> fcitx-table-other:
> * NEEDS INFO: debian/rules:
> override_dh_install:
>     find . -name *.mo -delete
> why stripping the generated .mo file? They aren't shown anyway in any UI?
>

No, they are not shown atm.

> ------
> -> librime:
> * BLOCKER: libkyotocabinet-dev, libmarisa-dev and libyaml-cpp-dev build-deps are in universe. Please add that one to the MIR if it matches the MIR criterias or drop those.

Added and checked.

> Note that libboost-signals-dev is in universe, but the source is in
main, so we can promote it as the same time.

> * MINOR: would be nice to multi-arch the library.
> * MINOR: it would be nice to have a .symbol file (not sure why there is an override no-symbols-control-file)

It makes little sense since the dependent data files aren't identical
across different architectures and upstream does not maintain it at
the moment.

> * MINOR: debian/copyright:
> Files: thirdparty/src/glog/*
>        thirdparty/src/gtest/*
> Copyright: 2008, Google Inc.
> It should be 1999-2008

http://anonscm.debian.org/cgit/pkg-
ime/librime.git/commit/?id=cac4f2a7fdfec25a572d22649195c8a76809ce81

> * MINOR/NEED INFO: any idea why the source has a priority extra?
>

Same reason as brise, changed anyway:
http://anonscm.debian.org/cgit/pkg-ime/librime.git/commit/?id=42ad5837d156057344559ee89635132a1b71dd3e

>
> Please fix those/provides feedback on them and reping me once done. :)
>
> Note when promoting (if promoting librime) -> push libboost-signals-dev
> binary to main.
>

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to presage in Ubuntu.
https://bugs.launchpad.net/bugs/1356222

Title:
  [MIR] fcitx and related packages

Status in “brise” package in Ubuntu:
  Incomplete
Status in “fcitx” package in Ubuntu:
  Incomplete
Status in “fcitx-anthy” package in Ubuntu:
  Incomplete
Status in “fcitx-chewing” package in Ubuntu:
  Fix Committed
Status in “fcitx-cloudpinyin” package in Ubuntu:
  Incomplete
Status in “fcitx-configtool” package in Ubuntu:
  Incomplete
Status in “fcitx-googlepinyin” package in Ubuntu:
  Incomplete
Status in “fcitx-hangul” package in Ubuntu:
  Incomplete
Status in “fcitx-m17n” package in Ubuntu:
  Incomplete
Status in “fcitx-qimpanel” package in Ubuntu:
  Incomplete
Status in “fcitx-qimpanel-configtool” package in Ubuntu:
  Incomplete
Status in “fcitx-qt5” package in Ubuntu:
  Incomplete
Status in “fcitx-rime” package in Ubuntu:
  Incomplete
Status in “fcitx-sunpinyin” package in Ubuntu:
  Incomplete
Status in “fcitx-table-extra” package in Ubuntu:
  Incomplete
Status in “fcitx-table-other” package in Ubuntu:
  Incomplete
Status in “kyotocabinet” package in Ubuntu:
  New
Status in “libgooglepinyin” package in Ubuntu:
  New
Status in “librime” package in Ubuntu:
  Incomplete
Status in “libtinyxml” package in Ubuntu:
  New
Status in “marisa” package in Ubuntu:
  New
Status in “presage” package in Ubuntu:
  New
Status in “yaml-cpp” package in Ubuntu:
  New

Bug description:
  [Availability]
  Currently in universe

  [Rationale]
  Fcitx is a replacement candidate for IBus

  [Security: ]
  CVE entries: none
  Security history: none
  Any binaries running as root or suid/sgid ? Any daemons ?
      -- all running as per user session, and /usr/bin/fcitx and /usr/bin/fcitx-qimpanel will run as daemon, /usr/bin/fcitx-dbus-watcher will be pulled up when fcitx is running.
  Network activity: does it open any port ? Does it handle incoming network data ?
      -- fcitx-cloudpinyin deals with network data by using libcurl and interact with remote API from several user-choosable providers.
  Does it directly (not through a library) process binary (video, audio, etc) or structured (PDF, etc) data ?
      -- no, it doesn't
  Any source code review performed ? (The approver will do a quick and shallow check.)
      -- no.

  [Quality Assurance]
  Package works out of the box with no prompting.
  There is no reproducible major bugs in Ubuntu and Debian.
  Upstream is active.
  Package is team maintained at Debian, and is the same people working on Debian and Ubuntu.

  Upstream bug tracker: https://github.com/fcitx/fcitx
  Hardware: Does this package deal with hardware and if so how exotic is it ?
      -- no
  Is there a test suite in the upstream source or packaging ? Is it enabled to run in the build ?
      -- yes, some fundamental tests

  [UI standards]
      User-visible strings are internationalized using standard gettext system ?
          -- yes
      Package with translatable strings builds a PO template during package build ?
          -- yes
      End-user applications ship a desktop file?
          -- fcitx and fcitx-ui-qimpanel do.

  [Standards Compliance]
  FHS and Debian Policy compliant.
  Packaging system (debhelper/cdbs/dbs) ? Patch system ? Any packaging oddities ?
      -- package is using debhelper,

  [Maintenance]
  Desktop Team will take care of them

  [Dependencies]
  librime and brise are for fcitx-rime.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/brise/+bug/1356222/+subscriptions