touch-packages team mailing list archive

[dolphy <1358368@xxxxxxxxxxxxxxxxxx>]

A simple fix would be :

--- /tmp/meld-tmp15YRFE
+++ /home/dolphy/oneplay-build/sources-devel/linux_x86_64/gst-fluendo-mp3-19/src/mp3-c.c
@@ -1659,7 +1659,7 @@
   if (diff < 0) {
     /* Usually happens after a seek. We can't decode this frame */
     GST_LOG ("Not enough main data available to decode frame");
-    return MP3TL_ERR_BAD_FRAME;
+    return MP3TL_ERR_NEED_DATA;
   }
 
   /* Copy the remaining main data in the bit reservoir to the start of the

This does not happen with the IPP version available on Fluendo's web
store which is also the binary build we provide to Canonical with the
MP3 patent license. Any version that you compile yourself without IPP is
not legally shipable under Fluendo's patent umbrella. (Might be worth
checking on your side).

Best regards,

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to gst-fluendo-mp3 in Ubuntu.
https://bugs.launchpad.net/bugs/1358368

Title:
  Seeking is broken with media-hub on versions 0.10.24 and above

Status in “gst-fluendo-mp3” package in Ubuntu:
  Confirmed

Bug description:
  Starting in version 0.10.24, the change to line 1656 of mp3-c.c causes
  seeking to break when used with media-hub (most likely a timing
  issue):

    diff = tl->c_impl.main_data_end - III_side_info.main_data_begin;
    if (diff < 0) {
      /* Usually happens after a seek. We can't decode this frame */
      GST_LOG ("Not enough main data available to decode frame");
      return MP3TL_ERR_BAD_FRAME;
    }

  Previously in version 0.10.23 and prior, this block inside the if
  statement was never executed:

    if (tl->c_impl.main_data_end - III_side_info.main_data_begin < 0) {
      /* Usually happens after a seek. We can't decode this frame */
      GST_LOG ("Not enough main data available to decode frame");
      return MP3TL_ERR_BAD_FRAME;
    }

  This needs reworking so that when this does happen after a seek, this
  code recovers gracefully instead of causing a pipeline flow error
  resulting in an EOS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gst-fluendo-mp3/+bug/1358368/+subscriptions