← Back to team overview

touch-packages team mailing list archive

[Bug 1358368] [NEW] Seeking is broken with media-hub on versions 0.10.24 and above

 

Public bug reported:

Starting in version 0.10.24, the change to line 1656 of mp3-c.c causes
seeking to break when used with media-hub (most likely a timing issue):

  diff = tl->c_impl.main_data_end - III_side_info.main_data_begin;
  if (diff < 0) {
    /* Usually happens after a seek. We can't decode this frame */
    GST_LOG ("Not enough main data available to decode frame");
    return MP3TL_ERR_BAD_FRAME;
  }

Previously in version 0.10.23 and prior, this block inside the if
statement was never executed:

  if (tl->c_impl.main_data_end - III_side_info.main_data_begin < 0) {
    /* Usually happens after a seek. We can't decode this frame */
    GST_LOG ("Not enough main data available to decode frame");
    return MP3TL_ERR_BAD_FRAME;
  }

This needs reworking so that when this does happen after a seek, this
code recovers gracefully instead of causing a pipeline flow error
resulting in an EOS.

** Affects: gst-fluendo-mp3 (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to gst-fluendo-mp3 in Ubuntu.
https://bugs.launchpad.net/bugs/1358368

Title:
  Seeking is broken with media-hub on versions 0.10.24 and above

Status in “gst-fluendo-mp3” package in Ubuntu:
  New

Bug description:
  Starting in version 0.10.24, the change to line 1656 of mp3-c.c causes
  seeking to break when used with media-hub (most likely a timing
  issue):

    diff = tl->c_impl.main_data_end - III_side_info.main_data_begin;
    if (diff < 0) {
      /* Usually happens after a seek. We can't decode this frame */
      GST_LOG ("Not enough main data available to decode frame");
      return MP3TL_ERR_BAD_FRAME;
    }

  Previously in version 0.10.23 and prior, this block inside the if
  statement was never executed:

    if (tl->c_impl.main_data_end - III_side_info.main_data_begin < 0) {
      /* Usually happens after a seek. We can't decode this frame */
      GST_LOG ("Not enough main data available to decode frame");
      return MP3TL_ERR_BAD_FRAME;
    }

  This needs reworking so that when this does happen after a seek, this
  code recovers gracefully instead of causing a pipeline flow error
  resulting in an EOS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gst-fluendo-mp3/+bug/1358368/+subscriptions


Follow ups

References