touch-packages team mailing list archive

[Matthew Paul Thomas <mpt@xxxxxxxxxxxxx>]

Public bug reported:

Currently, showing an app icon in the correct Ubuntu shape requires
shaping it when you are using it.

For example, ensuring that "iconFrame" is set to "True" when using ListItem.Standard{}.
<http://developer.ubuntu.com/api/devel/ubuntu-13.04/qml/ui-toolkit/qml-ubuntu-components-listitems0-standard.html>

That property is set to "True" by default, but it's not obvious why it
should be, and list items aren't the only place that app icons get used.
So they have now ended up the wrong shape multiple times: in the System
Settings "Updates" list (bug 1354478), in the "Notifications" screen,
and in the Launcher (bug 1332119). And conversely, System Settings has
also had a non-app icon that was inappropriately framed like an app (bug
1288866).

On the API design quality scale, this is roughly "Read the
implementation and you'll get it right." <http://sweng.the-
davies.net/Home/rustys-api-design-manifesto>

I suggest that the toolkit move all the way up to "It's impossible to
get wrong", by always shaping an icon when it is an app icon, and never
otherwise. Whether an icon is an app icon could (I assume) be detected
by its path.

** Affects: ubuntu-ui-toolkit (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1363015

Title:
  App icons require shaping at every callsite

Status in “ubuntu-ui-toolkit” package in Ubuntu:
  New

Bug description:
  Currently, showing an app icon in the correct Ubuntu shape requires
  shaping it when you are using it.

  For example, ensuring that "iconFrame" is set to "True" when using ListItem.Standard{}.
  <http://developer.ubuntu.com/api/devel/ubuntu-13.04/qml/ui-toolkit/qml-ubuntu-components-listitems0-standard.html>

  That property is set to "True" by default, but it's not obvious why it
  should be, and list items aren't the only place that app icons get
  used. So they have now ended up the wrong shape multiple times: in the
  System Settings "Updates" list (bug 1354478), in the "Notifications"
  screen, and in the Launcher (bug 1332119). And conversely, System
  Settings has also had a non-app icon that was inappropriately framed
  like an app (bug 1288866).

  On the API design quality scale, this is roughly "Read the
  implementation and you'll get it right." <http://sweng.the-
  davies.net/Home/rustys-api-design-manifesto>

  I suggest that the toolkit move all the way up to "It's impossible to
  get wrong", by always shaping an icon when it is an app icon, and
  never otherwise. Whether an icon is an app icon could (I assume) be
  detected by its path.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1363015/+subscriptions