← Back to team overview

touch-packages team mailing list archive

[Bug 479405] Re: --bwlimit option uses KiB/s, but is documented as (what amounts to) kB/s

 

This has been fixed in at least Ubuntu vivid.

** Changed in: rsync (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to rsync in Ubuntu.
https://bugs.launchpad.net/bugs/479405

Title:
  --bwlimit option uses KiB/s, but is documented as (what amounts to)
  kB/s

Status in rsync:
  Fix Released
Status in rsync package in Ubuntu:
  Fix Released

Bug description:
  Binary package hint: rsync

  The --bwlimit option seems to use KiB/s, as io.c's sleep_for_bwlimit() function
  divides by 1024. It's documented as "KBPS", "KBytes per second", and "kilobytes
  per second".

  I'm going to attach a patch which standardizes all of this as KiB/s and
  "kibibytes per second", to match the actual usage.

  Given that this is a network transfer rate, it'd be more proper (and consistent
  with other applications) to change the function to work in SI kilobytes per
  second (i.e. use 1000 instead of 1024), but that's backwards-incompatible. If
  you'd like to go this route, I can prepare a patch to that effect.

To manage notifications about this bug go to:
https://bugs.launchpad.net/rsync/+bug/479405/+subscriptions