← Back to team overview

touch-packages team mailing list archive

[Bug 1416293] [NEW] android container should not enable adb and mtp from default.prop

 

Public bug reported:

if the android container rootfs is built with ro.debuggable=1 it will
put a default.prop file into the container rootfs with
persist.sys.usb.config set to mtp,adb. on first boot after a factory
flach (not usin ubuntu-device-flash) when there was no value for this
property set prior to starting the container this causes the gadget to
be in adb mode without running adbd daemon. in his case the device will
show up as "offline" in "adb devices" on a PC until developer mode was
toggled once in the settings UI.

lxc-android-config needs to ship a pre-start.d snippet that removes this
entry from default.prop. this way recovery boots can still benefit from
ro.debuggable being set while adb behavior will not be affected in
normal boots.

---  /var/lib/lxc/android/pre-start.d/20-no-default-prop-adb ---

#! /bin/sh

sed -i '/^persist.sys.usb.config=.*/d' $LXC_ROOTFS_PATH/default.prop

---

** Affects: lxc-android-config (Ubuntu)
     Importance: High
     Assignee: Oliver Grawert (ogra)
         Status: In Progress

** Affects: lxc-android-config (Ubuntu RTM)
     Importance: High
     Assignee: Oliver Grawert (ogra)
         Status: In Progress

** Changed in: lxc-android-config (Ubuntu)
     Assignee: (unassigned) => Oliver Grawert (ogra)

** Changed in: lxc-android-config (Ubuntu)
       Status: New => In Progress

** Changed in: lxc-android-config (Ubuntu)
   Importance: Undecided => High

** Also affects: lxc-android-config (Ubuntu RTM)
   Importance: Undecided
       Status: New

** Changed in: lxc-android-config (Ubuntu RTM)
       Status: New => In Progress

** Changed in: lxc-android-config (Ubuntu RTM)
   Importance: Undecided => High

** Changed in: lxc-android-config (Ubuntu RTM)
     Assignee: (unassigned) => Oliver Grawert (ogra)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to lxc-android-config in
Ubuntu.
https://bugs.launchpad.net/bugs/1416293

Title:
  android container should not enable adb and mtp from default.prop

Status in lxc-android-config package in Ubuntu:
  In Progress
Status in lxc-android-config package in Ubuntu RTM:
  In Progress

Bug description:
  if the android container rootfs is built with ro.debuggable=1 it will
  put a default.prop file into the container rootfs with
  persist.sys.usb.config set to mtp,adb. on first boot after a factory
  flach (not usin ubuntu-device-flash) when there was no value for this
  property set prior to starting the container this causes the gadget to
  be in adb mode without running adbd daemon. in his case the device
  will show up as "offline" in "adb devices" on a PC until developer
  mode was toggled once in the settings UI.

  lxc-android-config needs to ship a pre-start.d snippet that removes
  this entry from default.prop. this way recovery boots can still
  benefit from ro.debuggable being set while adb behavior will not be
  affected in normal boots.

  ---  /var/lib/lxc/android/pre-start.d/20-no-default-prop-adb ---

  #! /bin/sh

  sed -i '/^persist.sys.usb.config=.*/d' $LXC_ROOTFS_PATH/default.prop

  ---

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc-android-config/+bug/1416293/+subscriptions


Follow ups

References