txawsteam team mailing list archive
-
txawsteam team
-
Mailing list archive
-
Message #00038
[Bug 415607] [NEW] Avoid accessing private parsing method
Public bug reported:
In a review comment, Jamu made the following observation:
+ def test_parse_reservation(self):
+ ec2 = client.EC2Client(creds='foo')
+ results = ec2._parse_reservation(sample_describe_instances_result)
+ self.check_parsed_reservations(results)
It would be nice to avoid accessing the private _parse_reservation
method by passing a query_factory to EC2Client that returns a
FakeQuery. FakeQuery.submit could return a succeeded deferred and
you could call ec2.describe_instances to get a Deferred with the
result you want to make assertions about.
** Affects: txaws
Importance: Wishlist
Status: New
** Changed in: txaws
Importance: Undecided => Wishlist
--
Avoid accessing private parsing method
https://bugs.launchpad.net/bugs/415607
You received this bug notification because you are a member of txAWS
Team, which is the registrant for txAWS.
Status in txAWS: Twisted Amazon: New
Bug description:
In a review comment, Jamu made the following observation:
+ def test_parse_reservation(self):
+ ec2 = client.EC2Client(creds='foo')
+ results = ec2._parse_reservation(sample_describe_instances_result)
+ self.check_parsed_reservations(results)
It would be nice to avoid accessing the private _parse_reservation
method by passing a query_factory to EC2Client that returns a
FakeQuery. FakeQuery.submit could return a succeeded deferred and
you could call ec2.describe_instances to get a Deferred with the
result you want to make assertions about.
Follow ups
References