u1db-discuss team mailing list archive

Thread
Date

Should get_from_index check for conflicts?

To: U1DB discuss <u1db-discuss@xxxxxxxxxxxxxxxxxxx>
From: John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>
Date: Wed, 07 Mar 2012 15:33:41 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Right now 'Database.get_doc()' will check for conflicts and set
Document.has_conflicts on the document it returns.

'Database.get_docs()' has a 'check_for_conflict' flag so callers can
set it true/false. The sync code specifically sets it to False because
it doesn't matter for sync, so it is wasted work to look it up and
ignore it.

We currently have a couple of tests that as a side effect are testing
that 'Database.get_from_index()' returns docs that don't set the
conflict flag. (I found out because the C implementation was using
get_doc() to build the object, which was causing it to get set.)

I can certainly set it one way or another, but I realized I didn't
really know what we want.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9XccUACgkQJdeBCYSNAANSDgCgh9iRubQ4t6v9ZzIQXFfJnKq/
XIAAniRL76ZoVC9qxLbwiI2kFvP66JBm
=ICJx
-----END PGP SIGNATURE-----