ubuntu-appstore-developers team mailing list archive

[Jamie Strandboge <jamie@xxxxxxxxxxxxx>]

On 08/20/2013 09:04 PM, Martin Albisetti wrote:
> On Tue, Aug 20, 2013 at 7:43 PM, Jamie Strandboge <jamie@xxxxxxxxxxxxx> wrote:
>>
>> Ah, where is yours? :)
>>
>> I've also run evilapp (mine) through this as well as some Ubuntu core apps and
>> made a number of adjustments to the scripts today.
> 
> 
> Mine is the "hello world" one, attached.
> 
It looks like it has many of the same issues as Michael's (presumably because it
was created with the SDK). Specifically:

 * it uses the old format for the manifest
 * it uses 1 for policy_version (should be 1.0)
 * there is no description in the manifest
 * it is using ar.com.beuno as the reverse domain instead of
   com.ubuntu.developers.beuno (not a problem per se, just noting it)
 * the filename uses a version that doesn't match the manifest and the
   DEBIAN/control file
 * the application name (ie, the key to the hooks database) contains an '_',
   which is illegal.

I also noticed it contains ar.com.beuno.hello_world_0.1_all.click.tar. Attached
is a patch against the unpacked click package to update it for the new hooks
format (and fixes the application name).

-- 
Jamie Strandboge                 http://www.ubuntu.com/

diff -Naurp ar.com.beuno.hello-world-0.2.orig/apparmor/hello_world.json ar.com.beuno.hello-world-0.2/apparmor/hello_world.json
--- ar.com.beuno.hello-world-0.2.orig/apparmor/hello_world.json	1969-12-31 18:00:00.000000000 -0600
+++ ar.com.beuno.hello-world-0.2/apparmor/hello_world.json	2013-08-21 07:26:27.440029236 -0500
@@ -0,0 +1,6 @@
+{
+    "policy_groups": [
+        "networking"
+    ],
+    "policy_version": 1.0
+}
diff -Naurp ar.com.beuno.hello-world-0.2.orig/DEBIAN/manifest ar.com.beuno.hello-world-0.2/DEBIAN/manifest
--- ar.com.beuno.hello-world-0.2.orig/DEBIAN/manifest	2013-08-20 13:53:16.000000000 -0500
+++ ar.com.beuno.hello-world-0.2/DEBIAN/manifest	2013-08-21 07:38:49.549638925 -0500
@@ -2,14 +2,10 @@
     "framework": "ubuntu-sdk-13.10",
     "maintainer": "Martin Albisetti <martin.albisetti@xxxxxxxxxxxxx>",
     "name": "ar.com.beuno.hello-world",
-    "security": {
-        "profiles": {
-            "hello_world": {
-                "policy_groups": [
-                    "networking"
-                ],
-                "policy_version": 1
-            }
+    "hooks": {
+        "hello-world": {
+            "apparmor": "apparmor/hello_world.json",
+            "desktop": "hello_world.desktop"
         }
     },
     "title": "Hello World",

Attachment: signature.asc
Description: OpenPGP digital signature