← Back to team overview

ubuntu-bengali-manual team mailing list archive

[Bug 714718] [NEW] lpupdate.py should check if the team_owner is a person (not a team)

 

Public bug reported:

The script /teams/management/commands/lpupdate.py checks for a changed
team_owner on launchpad, but it does not check if the owner is again a
team.

If the owner is a team, then the team_owner should be the owner of the owner_team (loco_team.team_owner.team_owner)
All the members of the owner_teams should become team admins in LD

the "is_admin_or_owner" check in launchpad.py will than be unneccairy
because it checks for
"team.admin_profiles.filter(user__username=username):". This will
increase the page speed for some pages in some special cases. And will
also remove inconsistency, because this is the only function that do
calls to launchpadlib on a page request. The other calls to launchpadlib
are all scheduled tasks

** Affects: loco-directory
     Importance: Undecided
         Status: New

** Description changed:

  The script /teams/management/commands/lpupdate.py checks for a changed
  team_owner on launchpad, but it does not check if the owner is again a
  team.
  
  If the owner is a team, then the team_owner should be the owner of the owner_team (loco_team.team_owner.team_owner)
  All the members of the owner_teams should become team admins in LD
+ 
+ the "is_admin_or_owner" check in launchpad.py will than be unneccairy
+ because it checks for
+ "team.admin_profiles.filter(user__username=username):". This will
+ increase the page speed for some pages in some special cases. And will
+ also remove inconsistency, because this is the only function that do
+ calls to launchpadlib on a page request. The other calls to launchpadlib
+ are all scheduled tasks

-- 
You received this bug notification because you are a member of Ubuntu
Bengali Manual, which is subscribed to loco-directory.
https://bugs.launchpad.net/bugs/714718

Title:
  lpupdate.py should check if the team_owner is a person (not a team)

Status in LoCo Directory:
  New

Bug description:
  The script /teams/management/commands/lpupdate.py checks for a changed
  team_owner on launchpad, but it does not check if the owner is again a
  team.

  If the owner is a team, then the team_owner should be the owner of the owner_team (loco_team.team_owner.team_owner)
  All the members of the owner_teams should become team admins in LD

  the "is_admin_or_owner" check in launchpad.py will than be unneccairy
  because it checks for
  "team.admin_profiles.filter(user__username=username):". This will
  increase the page speed for some pages in some special cases. And will
  also remove inconsistency, because this is the only function that do
  calls to launchpadlib on a page request. The other calls to
  launchpadlib are all scheduled tasks





Follow ups

References