ubuntu-bugcontrol team mailing list archive

[C de-Avillez <carlos.de.avillez@xxxxxxxxxxxxx>]

C de-Avillez has proposed merging lp:~hggdh2/ubuntu-qa-tools/bugsquad-membership into lp:ubuntu-qa-tools.

Requested reviews:
  Ubuntu Bug Control (ubuntu-bugcontrol)


bugsquad-membership.py:
  * add 'please read the triage guide' to the welcome message; 
  * automatically decline membership if CoC not signed, and give out reason.

-- 
https://code.launchpad.net/~hggdh2/ubuntu-qa-tools/bugsquad-membership/+merge/28806
Your team Ubuntu Bug Control is requested to review the proposed merge of lp:~hggdh2/ubuntu-qa-tools/bugsquad-membership into lp:ubuntu-qa-tools.

=== modified file 'launchpadlib-scripts/bugsquad-membership.py'
--- launchpadlib-scripts/bugsquad-membership.py	2010-04-05 15:58:09 +0000
+++ launchpadlib-scripts/bugsquad-membership.py	2010-06-29 22:45:36 +0000
@@ -27,7 +27,8 @@
     launchpad = Launchpad.get_token_and_login(script_name, EDGE_SERVICE_ROOT, cachedir)
     launchpad.credentials.save(open(credfile,"w",0600)) 
     
-welcome = "Thanks for helping to make Ubuntu even better and welcome to the team!" 
+welcome = "Thanks for helping to make Ubuntu even better and welcome to the team! Please read the Triage Guide at https://wiki.ubuntu.com/Bugs/HowToTriage/."; 
+declined = "Thank you for your interest in helping bug triaging and making Ubuntu better. We cannot approve your membership right now, since you did not complete all required steps (please see https://wiki.ubuntu.com/BugSquad). We have listed the basic requirements below:\n\n  * sign the Ubuntu Code of Conduct.\n  * Read the Triage Guide.\n  * Subscribe to the Bug Squad Mailing List.\n\nAfter you complete the previous steps, please reapply for membership on the BugSquad team at Launchpad, and we  will then approve your request.\n\n Again, thank you,"
 
 lpid = sys.argv[1]
 
@@ -68,4 +69,5 @@
             except HTTPError, error:
                 print state, error.content
 else:
-    print "%s: %s has not signed the CoC" % ( lpid, person.display_name )
+    print "%s: %s has not signed the CoC; declining request." % ( lpid, person.display_name )
+    team.addMember(person=person, status="Declined", comment=declined)