ubuntu-docker-images team mailing list archive

[Sergio Durigan Junior <sergio.durigan@xxxxxxxxxxxxx>]

On Tuesday, August 24 2021, Bryce Harrington wrote:

> I've adapted my bind9 oci to mirror Athos' work on the squid image.
> This is super preliminary and not tested so consider very WIP, but I'd
> appreciate a cursory look over for any course corrections needed:
>
>   https://code.launchpad.net/~bryce/ubuntu-docker-images/+git/bind9
>
> I haven't put much attention into the service parameters, so they're
> inconsistent from place to place.  Advice welcomed but fine to ignore
> for now.

Thanks, Bryce.

- The ENTRYPOINT statement on Dockerfile points to a non-existing
  filename.  It should be "entrypoint.sh".

- bind9's postinst already takes care of creating all of those
  directories (/etc/bind, /var/cache/bind, etc...).  You don't need to
  create them by hand.

- The entrypoint.sh handles extra args, which is good.  It can be
  simplified since we'll likely not use the functions.  It doesn't look
  like we'll need to BIND_USER and DATA_DIR variables either.

- There's a lot of unrelated bits in the data/bind9.yaml file, so I
  didn't review it.

> Should I use the standard bind9 port?  I notice other images
> (e.g. memcached) appear to be using semi-arbitrary port numbers?

Yeah, the service should listen on the default port number.  memcached
actually listens on the 11211 port, which is the default port for the
service :-).

> Do I have the right VOLUME values?  I'm a bit fuzzy on what this
> actually does.

Athos already covered this, but I think your VOLUMEs are fine.  I'm not
100% sure on the /var/log one (because it seems too generic), but the
others are certainly volumes that the user might want to mount.

Thanks,

-- 
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0  EB2F 106D A1C8 C3CB BF14