ubuntu-docker-images team mailing list archive

[Bryce Harrington <bryce.harrington@xxxxxxxxxxxxx>]

On Wed, Aug 25, 2021 at 03:28:16PM -0400, Sergio Durigan Junior wrote:
> On Tuesday, August 24 2021, Bryce Harrington wrote:
> 
> > I've adapted my bind9 oci to mirror Athos' work on the squid image.
> > This is super preliminary and not tested so consider very WIP, but I'd
> > appreciate a cursory look over for any course corrections needed:
> >
> >   https://code.launchpad.net/~bryce/ubuntu-docker-images/+git/bind9
> >
> > I haven't put much attention into the service parameters, so they're
> > inconsistent from place to place.  Advice welcomed but fine to ignore
> > for now.
> 
> Thanks, Bryce.
> 
> - The ENTRYPOINT statement on Dockerfile points to a non-existing
>   filename.  It should be "entrypoint.sh".

Thanks, forgot to update that from the initial Dockerfile.

> - bind9's postinst already takes care of creating all of those
>   directories (/etc/bind, /var/cache/bind, etc...).  You don't need to
>   create them by hand.

Good, I suspected so myself.

> - The entrypoint.sh handles extra args, which is good.  It can be
>   simplified since we'll likely not use the functions.  It doesn't look
>   like we'll need to BIND_USER and DATA_DIR variables either.

> - There's a lot of unrelated bits in the data/bind9.yaml file, so I
>   didn't review it.

Yeah probably those are the service parameters I haven't thought through
yet.

Thanks again for the prelim review.

Bryce