ubuntu-docker-images team mailing list archive

[Sergio Durigan Junior <sergio.durigan@xxxxxxxxxxxxx>]

On Thursday, March 31 2022, Athos Ribeiro wrote:

> On Wed, Mar 30, 2022 at 06:11:33PM -0400, Sergio Durigan Junior wrote:
>>On Monday, March 28 2022, Athos Ribeiro wrote:
>>
>>> On Tue, Mar 22, 2022 at 09:09:00PM -0400, Sergio Durigan Junior wrote:
>>
>>>>I have just finished putting together the first version of the Grafana
>>>>Loki Dockerfile.  It is heavily based on our other snap-based
>>>>Dockerfiles, specifically the one for Prometheus.
>>>>
>>>>I haven't written any documentation/tests for it yet; I intend to start
>>>>doing that next week.  The Loki snap is already available, which means
>>>>that this Dockerfile should work out of the box.
>>>>
>>>>Let me know what you think.  Thanks.
>>>
>>> Thanks! This LGTM :)
>>
>>Thanks!
>>
>>> I do have 2 questions regarding the Dockerfile:
>>>
>>>>VOLUME     [ "/loki" ]
>>>>WORKDIR    /loki
>>>
>>> Why did you decide to run containers from this directory and why should
>>> this directory be a volume?
>>
>>Good question.  I think this can be considered a leftover from the
>>prometheus Dockerfile, which I used as a base for this one.  Now that I
>>think more about it, I don't think it makes sense to keep these two
>>lines in the Dockerfile.
>>
>>If you're OK with this, I will remove these lines and push the branch to
>>the official repo.
>
> +1

Thanks, Athos.

I adjusted the Dockerfile and pushed the changes.

-- 
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0  EB2F 106D A1C8 C3CB BF14