ubuntu-multiseat team mailing list archive

[Laércio de Sousa <lbsousajr@xxxxxxxxx>]

Laércio de Sousa has proposed merging lp:~ubuntu-multiseat/lightdm/safe-login1-signal-subscribe into lp:lightdm.

Requested reviews:
  LightDM Development Team (lightdm-team)

For more details, see:
https://code.launchpad.net/~ubuntu-multiseat/lightdm/safe-login1-signal-subscribe/+merge/232283

Make g_dbus_connection_signal_subscribe() call in login1.c a little bit safer (really?)

TBH I'm not sure this change is really needed or safer, but, for some reason, this is the way signal subscription is done in GDM [1], so I'm proposing it here just in case.

[1] https://git.gnome.org/browse/gdm/tree/daemon/gdm-local-display-factory.c
-- 
https://code.launchpad.net/~ubuntu-multiseat/lightdm/safe-login1-signal-subscribe/+merge/232283
Your team Ubuntu Multiseat is subscribed to branch lp:~ubuntu-multiseat/lightdm/safe-login1-signal-subscribe.

=== modified file 'src/login1.c'
--- src/login1.c	2014-08-22 01:56:45 +0000
+++ src/login1.c	2014-08-26 18:26:51 +0000
@@ -348,8 +348,8 @@
                                                                    NULL,
                                                                    G_DBUS_SIGNAL_FLAGS_NONE,
                                                                    signal_cb,
-                                                                   service,
-                                                                   NULL);
+                                                                   g_object_ref (service),
+                                                                   g_object_unref);
 
     result = g_dbus_connection_call_sync (service->priv->connection,
                                           LOGIN1_SERVICE_NAME,