← Back to team overview

ubuntu-multiseat team mailing list archive

Re: [Merge] lp:~ubuntu-multiseat/lightdm/new-automatic-multiseat into lp:lightdm

 

> > seat = seat_new ("xlocal");
> 
> This should use the same logic as before for picking the seat type.

OK. Seat type is configurable now. Done in revisions 2042/2043.

> Reading the logind documentation we should ignore seats that have
> CanGraphical=false. We should watch for property changes on this, but it's not
> a blocker to landing this branch (since most real world cases probably wont
> have this change) - we can add it into another MP later.

OK.
 
> Needs at least one regression test. tests/scripts/multi-seat.conf breaks with
> this change (as expected). You will need to add #?*ADD-SEAT lines into this to
> make it work.

I'm still learning how to write test scripts for lightdm, nevertheless I've updated test/scripts/multi-seat.conf in revision 2041. For some reason, I was unable to test it in my local VirtualBox VM installation (running "make check" results in 100+ fails in my system). Could you please take a look and tell me if there's any errors in it?
-- 
https://code.launchpad.net/~ubuntu-multiseat/lightdm/new-automatic-multiseat/+merge/231903
Your team Ubuntu Multiseat is subscribed to branch lp:~ubuntu-multiseat/lightdm/new-automatic-multiseat.


References