ubuntu-packaging-guide-team team mailing list archive

[Andrew Starr-Bochicchio <a.starr.b@xxxxxxxxx>]

I don't know if you were read to resubmit or not, but I noticed a few things so I might as well bring it up.


1) I was think that somewhere in the beginning we should suggest reading the get started article first. Something like:

You will want to read the :doc:`Getting Set Up</getting-set-up>` article first
in order to prepare your development environment.

2)

+    $ sudo apt-get install build-essential cmake 

We don't really need to install cmake anymore.

3) One nice thing about the use of krqcode (despite it being broken) was that it did suggest how to trouble shoot a bit. Maybe the text before running ./configure could contain something like the following instead of just dropping the part about figuring out build-deps:

This will check for the required build dependencies. As ``hello`` is a simple
example, ``build-essential`` should provide everything we need. For more
complex programs, the command will fail if you do not have the needed libraries
and development files. Install the needed packages and repeat until the command
runs successfully.::

4)

+the plugin is a wrapper around the ``dh_make`` additionally make sure your
+in the directory where you have your hello tar file. command::

It might be nice to explain the required arguments to "bzr dh_make" and make that last bit a complete sentence.

The plugin is a wrapper around the ``dh_make`` command. You should already
have these if you installed ``packaging-dev`` Run the command providing the
package name, version number, and path to the upstream tarball::

5)

+    $ cd hellorm/debian

I think you mean: $ cd hello/debian

6)

-version number to an Ubuntu version: ``0.4-0ubuntu1`` (upstream version 0.4,
+version number to an Ubuntu version: ``2.7-1ubuntu1`` (upstream version 2.7,
 Debian version 0, Ubuntu version 1).  Also change ``unstable`` to the current
 development Ubuntu release such as ``oneiric``.

Let's use the version 2.7-0ubuntu1. We might as well change oneiric to precise while we're at it.

7)

+describes the source package. The second and and following paragraphs describe

We've got an extra "and" there.

8) Bellow there are multiple references to  hello_2.7-1.dsc and hello_2.7-1_amd64.deb. If we actually follow the guide we should be ending up with hello_2.7-0ubuntu1.dsc and hello_2.7-0ubuntu1.deb


Thanks for working on this!
-- 
https://code.launchpad.net/~kinggoddard/ubuntu-packaging-guide/913934-fix/+merge/91773
Your team Ubuntu Packaging Guide Team is subscribed to branch lp:ubuntu-packaging-guide.